Re: [Mesa-dev] [PATCH] glsl: correctly handle inout parameters post function inlining

Sounds good to me, go ahead and push the new version! On Fri, May 6, 2016 at 10:44 AM, Juan A. Suarez Romero wrote: > On Fri, 2016-05-06 at 10:39 -0400, Lars Hamre wrote: >> Hi Juan, >> >> Sorry I missed that. >> >> It looks like your patch doesn't fix the out parameter

Re: [Mesa-dev] [PATCH] glsl: correctly handle inout parameters post function inlining

On Fri, 2016-05-06 at 10:39 -0400, Lars Hamre wrote: > Hi Juan, > > Sorry I missed that. > > It looks like your patch doesn't fix the out parameter indexing for: > vs-inout-index-inout-mat2-col > vs-inout-index-inout-vec4-array > > I was able to extend your patch to get these tests passing by:

Re: [Mesa-dev] [PATCH] glsl: correctly handle inout parameters post function inlining

I think you want a loop there, peeling off all array dereferences, due to AoA (and maybe throw in some piglit tests to cover that). [Assuming AoA's can be function arguments... haven't checked the spec.] On Fri, May 6, 2016 at 10:39 AM, Lars Hamre wrote: > Hi Juan, > > Sorry

Re: [Mesa-dev] [PATCH] glsl: correctly handle inout parameters post function inlining

Hi Juan, Sorry I missed that. It looks like your patch doesn't fix the out parameter indexing for: vs-inout-index-inout-mat2-col vs-inout-index-inout-vec4-array I was able to extend your patch to get these tests passing by: - if the ir_array->array was a dereferenced_array, copy propagate

Re: [Mesa-dev] [PATCH] glsl: correctly handle inout parameters post function inlining

On Fri, 2016-05-06 at 08:49 -0400, Lars Hamre wrote: > Inout parameters which depended on other inout parameters > where not assigned in the correct order. > > Fixes the following piglit tests in shaders/out-parameter-indexing: > vs-inout-index-inout-float-array > vs-inout-index-inout-mat2-col >

[Mesa-dev] [PATCH] glsl: correctly handle inout parameters post function inlining

Inout parameters which depended on other inout parameters where not assigned in the correct order. Fixes the following piglit tests in shaders/out-parameter-indexing: vs-inout-index-inout-float-array vs-inout-index-inout-mat2-col vs-inout-index-inout-mat2-row vs-inout-index-inout-vec4