Re: [Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

2013-08-19 Thread Marek Olšák
Hi Ian, In case you're interested, I have noticed we have no piglit tests for GL_ARB_base_instance. For example, baseinstance shouldn't affect gl_InstanceID, which is currently broken in radeonsi. Marek On Sun, Aug 18, 2013 at 5:23 AM, Ian Romanick wrote: > On 08/09/2013 01:40 PM, Marek Olšák w

Re: [Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

2013-08-18 Thread Henri Verbeet
On 18 August 2013 05:23, Ian Romanick wrote: > Since this also fixes an application, do you have any idea what could be > done to make a piglit test to reproduce the failure? We have some folks > writing piglit tests for us this summer, and this sounds like a good one for > them. :) > The basic s

Re: [Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

2013-08-17 Thread Ian Romanick
On 08/09/2013 01:40 PM, Marek Olšák wrote: Tested by examining generated TGSI shaders from piglit/glsl-routing. Cc: mesa-sta...@lists.freedesktop.org This patch was in my review-queue, and I forgot about it. Sorry. :( Reviewed-by: Ian Romanick Since this also fixes an application, do you h

Re: [Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

2013-08-17 Thread Henri Verbeet
On 9 August 2013 22:40, Marek Olšák wrote: > > Tested by examining generated TGSI shaders from piglit/glsl-routing. > This fixes the relevant Wine d3d9 test, thanks. No piglit changes on Cayman. Reviewed-by: Henri Verbeet Tested-by: Henri Verbeet ___

[Mesa-dev] [PATCH] glsl: don't eliminate texcoords that can be set by GL_COORD_REPLACE

2013-08-09 Thread Marek Olšák
Tested by examining generated TGSI shaders from piglit/glsl-routing. Cc: mesa-sta...@lists.freedesktop.org --- src/glsl/ir_optimization.h | 2 +- src/glsl/linker.cpp| 6 +++--- src/glsl/opt_dead_builtin_varyings.cpp | 27 +++ 3 files chang