Re: [Mesa-dev] [PATCH] glsl: fix and clean up NV_compute_shader_derivatives support

2019-05-01 Thread Marek Olšák
Yeah, I'll try to add descriptive commit messages next time. Marek On Wed, May 1, 2019 at 11:22 PM Timothy Arceri wrote: > I feel like I've asked this before but can you please try to add commit > proper commit messages. Not adding a proper commit message might save > you a minute or two but

Re: [Mesa-dev] [PATCH] glsl: fix and clean up NV_compute_shader_derivatives support

2019-05-01 Thread Caio Marcelo de Oliveira Filho
Sorry, missed this one. It seems https://github.com/KhronosGroup/GLSL/blob/master/extensions/nv/GLSL_NV_compute_shader_derivatives.txt don't explicitly mention the interaction with EXT_texture_array but seems reasonable to enable those. This patch is Reviewed-by: Caio Marcelo de Oliveira Filho

Re: [Mesa-dev] [PATCH] glsl: fix and clean up NV_compute_shader_derivatives support

2019-05-01 Thread Timothy Arceri
I feel like I've asked this before but can you please try to add commit proper commit messages. Not adding a proper commit message might save you a minute or two but it cost much more than a minute or two for those trying to review a patch or that have bisect to the commit, used git blame, git

Re: [Mesa-dev] [PATCH] glsl: fix and clean up NV_compute_shader_derivatives support

2019-05-01 Thread Marek Olšák
Ping On Wed, Apr 24, 2019 at 1:30 PM Marek Olšák wrote: > From: Marek Olšák > > --- > src/compiler/glsl/builtin_functions.cpp | 78 - > 1 file changed, 24 insertions(+), 54 deletions(-) > > diff --git a/src/compiler/glsl/builtin_functions.cpp >

[Mesa-dev] [PATCH] glsl: fix and clean up NV_compute_shader_derivatives support

2019-04-24 Thread Marek Olšák
From: Marek Olšák --- src/compiler/glsl/builtin_functions.cpp | 78 - 1 file changed, 24 insertions(+), 54 deletions(-) diff --git a/src/compiler/glsl/builtin_functions.cpp b/src/compiler/glsl/builtin_functions.cpp index c8d9e1c9af3..b1ffafa1acf 100644 ---