Re: [Mesa-dev] [PATCH] glsl: handle unsigned int wraparound in link_shaders()

2016-04-08 Thread Lars Hamre
Agreed, I didn't see that check_explicit_uniform_locations() was only used in link_shaders(). I will submit a v2 with those changes. On Thu, Apr 7, 2016 at 11:24 PM, Timothy Arceri < timothy.arc...@collabora.com> wrote: > On Thu, 2016-04-07 at 11:22 -0400, Lars Hamre wrote: > > NOTES: > > * Repos

Re: [Mesa-dev] [PATCH] glsl: handle unsigned int wraparound in link_shaders()

2016-04-07 Thread Timothy Arceri
On Thu, 2016-04-07 at 11:22 -0400, Lars Hamre wrote: > NOTES: > * Reposting due to no response last week > * Someone with access will need to commit this patch after the review >   process > > check_explicit_uniform_locations() returns a -1 when the extension > ARB_explicit_uniform_location is not

[Mesa-dev] [PATCH] glsl: handle unsigned int wraparound in link_shaders()

2016-04-07 Thread Lars Hamre
NOTES: * Reposting due to no response last week * Someone with access will need to commit this patch after the review process check_explicit_uniform_locations() returns a -1 when the extension ARB_explicit_uniform_location is not found. We were storing the result in num_explicit_uniform_locs as

[Mesa-dev] [PATCH] glsl: handle unsigned int wraparound in link_shaders()

2016-03-30 Thread Lars Hamre
check_explicit_uniform_locations() returns a -1 when the extension ARB_explicit_uniform_location is not found. We were storing the result in num_explicit_uniform_locs as an unsigned int which caused it to be 4294967295 when a -1 was returned. This in turn would cause the following error during li