Re: [Mesa-dev] [PATCH] glsl: move uniform calculation to link_uniforms

2016-01-16 Thread Timothy Arceri
On Sun, 2016-01-17 at 07:09 +0200, Tapani Pälli wrote: > On 01/17/2016 04:56 AM, Timothy Arceri wrote: > > On Sat, 2016-01-16 at 07:40 +0200, Tapani Pälli wrote: > > > Patch moves uniform calculation to happen during link_uniforms, > > Hi Tapani, > > > > I like that you are moving the check here a

Re: [Mesa-dev] [PATCH] glsl: move uniform calculation to link_uniforms

2016-01-16 Thread Tapani Pälli
On 01/17/2016 04:56 AM, Timothy Arceri wrote: On Sat, 2016-01-16 at 07:40 +0200, Tapani Pälli wrote: Patch moves uniform calculation to happen during link_uniforms, Hi Tapani, I like that you are moving the check here as it allows arrays without an explicit location to be resized before the ma

Re: [Mesa-dev] [PATCH] glsl: move uniform calculation to link_uniforms

2016-01-16 Thread Tapani Pälli
On 01/17/2016 12:32 AM, Matt Turner wrote: On Fri, Jan 15, 2016 at 9:40 PM, Tapani Pälli wrote: Patch moves uniform calculation to happen during link_uniforms, this is possible with help of UniformRemapTable that has all the reserved locations. Location assignment for implicit locations is cha

Re: [Mesa-dev] [PATCH] glsl: move uniform calculation to link_uniforms

2016-01-16 Thread Timothy Arceri
On Sat, 2016-01-16 at 07:40 +0200, Tapani Pälli wrote: > Patch moves uniform calculation to happen during link_uniforms, Hi Tapani, I like that you are moving the check here as it allows arrays without an explicit location to be resized before the max check is done. However I'm not too excited ab

Re: [Mesa-dev] [PATCH] glsl: move uniform calculation to link_uniforms

2016-01-16 Thread Matt Turner
On Fri, Jan 15, 2016 at 9:40 PM, Tapani Pälli wrote: > Patch moves uniform calculation to happen during link_uniforms, this > is possible with help of UniformRemapTable that has all the reserved > locations. > > Location assignment for implicit locations is changed so that we > utilize also the 'h

[Mesa-dev] [PATCH] glsl: move uniform calculation to link_uniforms

2016-01-15 Thread Tapani Pälli
Patch moves uniform calculation to happen during link_uniforms, this is possible with help of UniformRemapTable that has all the reserved locations. Location assignment for implicit locations is changed so that we utilize also the 'holes' that explicit uniform location assignment might have left i