Re: [Mesa-dev] [PATCH] glsl: properly setting var-data.binding if explicit_binding is true

2015-04-27 Thread Timothy Arceri
Timothy Arceri wrote On Sun, 2015-04-26 at 15:23 +0200, Alejandro Piñeiro wrote: On 26/04/15 00:08, Timothy Arceri wrote: On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: There was a typo on commit c0cd5b, doing it when explicit_binding was false. This prevented

Re: [Mesa-dev] [PATCH] glsl: properly setting var-data.binding if explicit_binding is true

2015-04-27 Thread Timothy Arceri
On Sun, 2015-04-26 at 15:23 +0200, Alejandro Piñeiro wrote: On 26/04/15 00:08, Timothy Arceri wrote: On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: There was a typo on commit c0cd5b, doing it when explicit_binding was false. This prevented to use any binding point different to

Re: [Mesa-dev] [PATCH] glsl: properly setting var-data.binding if explicit_binding is true

2015-04-27 Thread Emil Velikov
Hi Alejandro On 26 April 2015 at 14:23, Alejandro Piñeiro apinhe...@igalia.com wrote: On 26/04/15 00:08, Timothy Arceri wrote: On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: There was a typo on commit c0cd5b, doing it when explicit_binding was false. This prevented to use any

Re: [Mesa-dev] [PATCH] glsl: properly setting var-data.binding if explicit_binding is true

2015-04-26 Thread Alejandro Piñeiro
On 26/04/15 00:08, Timothy Arceri wrote: On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: There was a typo on commit c0cd5b, doing it when explicit_binding was false. This prevented to use any binding point different to 0. --- Taking into account the explanation on the header

Re: [Mesa-dev] [PATCH] glsl: properly setting var-data.binding if explicit_binding is true

2015-04-25 Thread Timothy Arceri
On Sat, 2015-04-25 at 18:46 +0200, Alejandro Piñeiro wrote: There was a typo on commit c0cd5b, doing it when explicit_binding was false. This prevented to use any binding point different to 0. --- Taking into account the explanation on the header about the variable binding (ast.h:553)

[Mesa-dev] [PATCH] glsl: properly setting var-data.binding if explicit_binding is true

2015-04-25 Thread Alejandro Piñeiro
There was a typo on commit c0cd5b, doing it when explicit_binding was false. This prevented to use any binding point different to 0. --- Taking into account the explanation on the header about the variable binding (ast.h:553) /** * Binding specified via GL_ARB_shading_language_420pack's