Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

2016-05-09 Thread Jose Fonseca
On 09/05/16 12:29, Eric Anholt wrote: Ian Romanick writes: On 05/03/2016 10:17 PM, Eric Anholt wrote: Brian Paul writes: On 05/02/2016 06:15 PM, Ilia Mirkin wrote: I know I've been sticking commas at the end of enums left and right for the past several years, and haven't heard any complai

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

2016-05-09 Thread Eric Anholt
Ian Romanick writes: > On 05/03/2016 10:17 PM, Eric Anholt wrote: >> Brian Paul writes: >> >>> On 05/02/2016 06:15 PM, Ilia Mirkin wrote: I know I've been sticking commas at the end of enums left and right for the past several years, and haven't heard any complaints. The nice thi

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

2016-05-09 Thread Ian Romanick
On 05/03/2016 10:17 PM, Eric Anholt wrote: > Brian Paul writes: > >> On 05/02/2016 06:15 PM, Ilia Mirkin wrote: >>> I know I've been sticking commas at the end of enums left and right >>> for the past several years, and haven't heard any complaints. The nice >>> thing about the trailing comma is

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

2016-05-03 Thread Eric Anholt
Brian Paul writes: > On 05/02/2016 06:15 PM, Ilia Mirkin wrote: >> I know I've been sticking commas at the end of enums left and right >> for the past several years, and haven't heard any complaints. The nice >> thing about the trailing comma is that you avoid having to change >> unrelated lines

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

2016-05-02 Thread Brian Paul
On 05/02/2016 06:15 PM, Ilia Mirkin wrote: I know I've been sticking commas at the end of enums left and right for the past several years, and haven't heard any complaints. The nice thing about the trailing comma is that you avoid having to change unrelated lines when adding entries. This leads t

Re: [Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

2016-05-02 Thread Ilia Mirkin
I know I've been sticking commas at the end of enums left and right for the past several years, and haven't heard any complaints. The nice thing about the trailing comma is that you avoid having to change unrelated lines when adding entries. This leads to cleaner per-line histories, which can be us

[Mesa-dev] [PATCH] glsl: remove trailing comma in enum lists to silence warning

2016-05-02 Thread Brian Paul
Silences warnings from -Wpedantic: In file included from ../../src/compiler/glsl/glsl_symbol_table.h:34:0, from ../../src/compiler/glsl/glsl_parser_extras.h:35, from nir/glsl_to_nir.h:29, from nir/glsl_to_nir.cpp:51: ../../src/compiler/glsl/ir.h:37