Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-04-11 Thread Timothy Arceri
On 11/04/18 20:50, Emil Velikov wrote: On 10 April 2018 at 18:10, Jason Ekstrand wrote: On Tue, Apr 10, 2018 at 10:05 AM, Emil Velikov wrote: On 10 April 2018 at 17:53, Ivan Kalvachev wrote: On 3/28/18, Emil Velikov

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-04-11 Thread Ivan Kalvachev
On 4/11/18, Ivan Kalvachev wrote: > On 4/11/18, Emil Velikov wrote: >> On 10 April 2018 at 18:10, Jason Ekstrand wrote: >>> On Tue, Apr 10, 2018 at 10:05 AM, Emil Velikov >>> >>> wrote: On

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-04-11 Thread Ivan Kalvachev
On 4/11/18, Emil Velikov wrote: > On 10 April 2018 at 18:10, Jason Ekstrand wrote: >> On Tue, Apr 10, 2018 at 10:05 AM, Emil Velikov >> wrote: >>> >>> On 10 April 2018 at 17:53, Ivan Kalvachev

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-04-11 Thread Emil Velikov
On 10 April 2018 at 18:10, Jason Ekstrand wrote: > On Tue, Apr 10, 2018 at 10:05 AM, Emil Velikov > wrote: >> >> On 10 April 2018 at 17:53, Ivan Kalvachev wrote: >> > On 3/28/18, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-04-10 Thread Jason Ekstrand
On Tue, Apr 10, 2018 at 10:05 AM, Emil Velikov wrote: > On 10 April 2018 at 17:53, Ivan Kalvachev wrote: > > On 3/28/18, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> Earlier commit

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-04-10 Thread Emil Velikov
On 10 April 2018 at 17:53, Ivan Kalvachev wrote: > On 3/28/18, Emil Velikov wrote: >> From: Emil Velikov >> >> Earlier commit enforced that we'll bail out if the number of terminators >> is different than 2. With that

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-04-10 Thread Ivan Kalvachev
On 3/28/18, Emil Velikov wrote: > From: Emil Velikov > > Earlier commit enforced that we'll bail out if the number of terminators > is different than 2. With that in mind, the assert() will never trigger. > > Fixes: 56b867395de ("glsl: fix

Re: [Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-03-28 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 29/03/18 04:25, Emil Velikov wrote: From: Emil Velikov Earlier commit enforced that we'll bail out if the number of terminators is different than 2. With that in mind, the assert() will never trigger. Fixes:

[Mesa-dev] [PATCH] glsl: remove unreachable assert()

2018-03-28 Thread Emil Velikov
From: Emil Velikov Earlier commit enforced that we'll bail out if the number of terminators is different than 2. With that in mind, the assert() will never trigger. Fixes: 56b867395de ("glsl: fix infinite loop caused by bug in loop unrolling pass") Cc: Timothy Arceri