[Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

2017-11-06 Thread Brian Paul
Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Update glsl_type constructor to take glsl_base_type intead of unsigned and pass GLSL_TYPE_VOID instead of zero. No Piglit regressions with llvmpipe. --- src/com

Re: [Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

2017-11-06 Thread Ian Romanick
On 11/06/2017 01:00 PM, Brian Paul wrote: > Declare glsl_type::sampled_type as glsl_base_type as we do for the > base_type field. And make base_type a bitfield to save a few bytes. Hmm... I have mixed feelings about this. I made a conscious decision to have base_type be "full size" because it's

Re: [Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

2017-11-06 Thread Brian Paul
On 11/06/2017 02:27 PM, Ian Romanick wrote: On 11/06/2017 01:00 PM, Brian Paul wrote: Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Hmm... I have mixed feelings about this. I made a conscious decision to

Re: [Mesa-dev] [PATCH] glsl: s/unsigned/glsl_base_type/ in glsl type code

2017-11-07 Thread Ian Romanick
On 11/06/2017 02:54 PM, Brian Paul wrote: > On 11/06/2017 02:27 PM, Ian Romanick wrote: >> On 11/06/2017 01:00 PM, Brian Paul wrote: >>> Declare glsl_type::sampled_type as glsl_base_type as we do for the >>> base_type field.  And make base_type a bitfield to save a few bytes. >> >> Hmm... I have mi