Re: [Mesa-dev] [PATCH] glsl: simplify validation of illegal layouts on block members

2015-11-12 Thread Timothy Arceri
On Thu, 2015-11-12 at 13:59 +0100, Iago Toral wrote: > On Thu, 2015-11-12 at 16:13 +1100, Timothy Arceri wrote: > > From: Timothy Arceri > > > > We already give the location of the qualifier so there is > > no need to list all the identifiers in the error message. > > However, there can be multi

Re: [Mesa-dev] [PATCH] glsl: simplify validation of illegal layouts on block members

2015-11-12 Thread Iago Toral
On Thu, 2015-11-12 at 16:13 +1100, Timothy Arceri wrote: > From: Timothy Arceri > > We already give the location of the qualifier so there is > no need to list all the identifiers in the error message. However, there can be multiple layout qualifiers in the same declaration and in that case, wit

[Mesa-dev] [PATCH] glsl: simplify validation of illegal layouts on block members

2015-11-11 Thread Timothy Arceri
From: Timothy Arceri We already give the location of the qualifier so there is no need to list all the identifiers in the error message. Also not calling the binding validation function will make things much simpler when adding compile time constant support as we wont need to resolve the binding