Re: [Mesa-dev] [PATCH] glsl: use bitfield_insert instead of and + shift + or for packing

2015-08-27 Thread Ilia Mirkin
On Fri, Aug 28, 2015 at 2:20 AM, Matt Turner wrote: > On Thu, Aug 20, 2015 at 6:00 PM, Ilia Mirkin wrote: >> It is fairly tricky to detect the proper conditions for using bitfield >> insert, but easy to just use it up front. This removes a lot of >> instructions on nvc0 when invoking the packing

Re: [Mesa-dev] [PATCH] glsl: use bitfield_insert instead of and + shift + or for packing

2015-08-27 Thread Matt Turner
On Thu, Aug 20, 2015 at 6:00 PM, Ilia Mirkin wrote: > It is fairly tricky to detect the proper conditions for using bitfield > insert, but easy to just use it up front. This removes a lot of > instructions on nvc0 when invoking the packing builtins. > > Signed-off-by: Ilia Mirkin > --- > > Not su

[Mesa-dev] [PATCH] glsl: use bitfield_insert instead of and + shift + or for packing

2015-08-20 Thread Ilia Mirkin
It is fairly tricky to detect the proper conditions for using bitfield insert, but easy to just use it up front. This removes a lot of instructions on nvc0 when invoking the packing builtins. Signed-off-by: Ilia Mirkin --- Not sure if all backends will benefit from this, but nvc0 definitely does