Re: [Mesa-dev] [PATCH] glthread: get rid of unmarshal dispatch enum/table

2017-07-07 Thread Grigori Goronzy
On 2017-07-01 18:46, Marek Olšák wrote: Instead of passing the function pointer through the queue, passing just a call ID (uint16_t) is preferable. If the switch statement is an issue, doing a function pointer lookup from a static array should be OK. OK, then let's drop this patch. gcc turns

Re: [Mesa-dev] [PATCH] glthread: get rid of unmarshal dispatch enum/table

2017-07-01 Thread Marek Olšák
Instead of passing the function pointer through the queue, passing just a call ID (uint16_t) is preferable. If the switch statement is an issue, doing a function pointer lookup from a static array should be OK. Marek On Fri, Jun 30, 2017 at 7:14 PM, Grigori Goronzy wrote: > On 2017-06-30 15:27,

Re: [Mesa-dev] [PATCH] glthread: get rid of unmarshal dispatch enum/table

2017-06-30 Thread Grigori Goronzy
On 2017-06-30 15:27, Nicolai Hähnle wrote: On 30.06.2017 02:29, Grigori Goronzy wrote: Use function pointers to identify the unmarshalling function, which is simpler and gets rid of a lot generated code. This removes an indirection and possibly results in a slight speedup as well. The fact th

Re: [Mesa-dev] [PATCH] glthread: get rid of unmarshal dispatch enum/table

2017-06-30 Thread Nicolai Hähnle
On 30.06.2017 02:29, Grigori Goronzy wrote: Use function pointers to identify the unmarshalling function, which is simpler and gets rid of a lot generated code. This removes an indirection and possibly results in a slight speedup as well. The fact that it blows up cmd_base from 4 bytes to 16 b

[Mesa-dev] [PATCH] glthread: get rid of unmarshal dispatch enum/table

2017-06-29 Thread Grigori Goronzy
Use function pointers to identify the unmarshalling function, which is simpler and gets rid of a lot generated code. This removes an indirection and possibly results in a slight speedup as well. --- src/mapi/glapi/gen/Makefile.am | 4 -- src/mapi/glapi/gen/gl_marshal.py | 36 ++