Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Chuck Atkins
Hi George, This first showed up on one of our older dashboard machines without AVX (Nehalem processor). You can easily reproduce it by building with --with-swr-archs=knl,skx when the machine you're trying to use it on is neither. Note that dri-glx seems to handle this case just fine but xlib-gl

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Kyriazis, George
I believed I created the same failure by deleting libswr*.so, however in my case (running glxgears) I hit a SEGV in XMesaCreateVisual (calling xmdpy->screen->is_format_supported()), because xmesa_init_display() created an xmdpy with a NULL screen. I never get to the xmesa_close_display(). Were

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Kyriazis, George
Chuck, In which cases do you hit this? When an architecture is not supported, then swr_create_screen() falls back to a different (older) architecture. Thanks, George > On Feb 21, 2018, at 8:26 AM, Chuck Atkins wrote: > > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is >

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Eric Engestrom
On Wednesday, 2018-02-21 09:48:54 -0500, Chuck Atkins wrote: > > > - if (xmdpy->smapi->destroy) > > > - xmdpy->smapi->destroy(xmdpy->smapi); > > > - free(xmdpy->smapi); > > > + if (xmdpy->smapi) > > > + { > > > + if (xmdpy->smapi->destroy) > > > + xmdpy->smapi->destroy(xmd

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Chuck Atkins
> > - if (xmdpy->smapi->destroy) > > - xmdpy->smapi->destroy(xmdpy->smapi); > > - free(xmdpy->smapi); > > + if (xmdpy->smapi) > > + { > > + if (xmdpy->smapi->destroy) > > + xmdpy->smapi->destroy(xmdpy->smapi); > > + free(xmdpy->smapi); > > + } > > I don't know this

Re: [Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Eric Engestrom
On Wednesday, 2018-02-21 09:26:34 -0500, Chuck Atkins wrote: > This fixes a segfault exposed by a29d63ecf7 which occurs when swr is > used on an unsupported architecture. > > Signed-off-by: Chuck Atkins > Cc: mesa-sta...@lists.freedesktop.org > Cc: George Kyriazis > Cc: Bruce Cherniak > --- >

[Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-21 Thread Chuck Atkins
This fixes a segfault exposed by a29d63ecf7 which occurs when swr is used on an unsupported architecture. Signed-off-by: Chuck Atkins Cc: mesa-sta...@lists.freedesktop.org Cc: George Kyriazis Cc: Bruce Cherniak --- src/gallium/state_trackers/glx/xlib/xm_api.c | 11 +++ 1 file changed,

[Mesa-dev] [PATCH] glx: Properly handle cases where screen creation fails

2018-02-20 Thread Chuck Atkins
This fixed a segfault exposed by a29d63ecf7 which occurs when swr is used on an unsupported architecture. Signed-off-by: Chuck Atkins Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/state_trackers/glx/xlib/xm_api.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --g