Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Adam Jackson
On Mon, 2011-12-19 at 16:45 +0100, Michel Dänzer wrote: > On Mon, 2011-12-19 at 10:14 -0500, Adam Jackson wrote: > > > The server is the only thing that knows how to handle this scenario, and > > it _can_ get this request, so you have to fix it there anyway. > > Actually no, the DRI2 code in the

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Michel Dänzer
On Mon, 2011-12-19 at 10:14 -0500, Adam Jackson wrote: > On Mon, 2011-12-19 at 09:40 +, Dave Airlie wrote: > > On Wed, Dec 7, 2011 at 6:32 PM, Eric Anholt wrote: > > > On Wed, 7 Dec 2011 10:24:09 +, Dave Airlie wrote: > > >> From: Dave Airlie > > >> > > >> This keeps track of the creat

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Adam Jackson
On Mon, 2011-12-19 at 09:40 +, Dave Airlie wrote: > On Wed, Dec 7, 2011 at 6:32 PM, Eric Anholt wrote: > > On Wed, 7 Dec 2011 10:24:09 +, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> This keeps track of the creation process and stores a drawable type, > >> it then blocks DRI2 fro

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-19 Thread Dave Airlie
On Wed, Dec 7, 2011 at 6:32 PM, Eric Anholt wrote: > On Wed,  7 Dec 2011 10:24:09 +, Dave Airlie wrote: >> From: Dave Airlie >> >> This keeps track of the creation process and stores a drawable type, >> it then blocks DRI2 from getting called if the drawable is a pixmap. >> >> v2: check if w

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-07 Thread Eric Anholt
On Wed, 7 Dec 2011 10:24:09 +, Dave Airlie wrote: > From: Dave Airlie > > This keeps track of the creation process and stores a drawable type, > it then blocks DRI2 from getting called if the drawable is a pixmap. > > v2: check if we have a GLX drawable, which means we aren't a pbuffer, >

Re: [Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-07 Thread Michel Dänzer
On Mit, 2011-12-07 at 10:24 +, Dave Airlie wrote: > From: Dave Airlie > > This keeps track of the creation process and stores a drawable type, > it then blocks DRI2 from getting called if the drawable is a pixmap. > > v2: check if we have a GLX drawable, which means we aren't a pbuffer, > a

[Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

2011-12-07 Thread Dave Airlie
From: Dave Airlie This keeps track of the creation process and stores a drawable type, it then blocks DRI2 from getting called if the drawable is a pixmap. v2: check if we have a GLX drawable, which means we aren't a pbuffer, avoid doing flush at all since its meant to be a no-op. Suggested by