Re: [Mesa-dev] [PATCH] gm107/ir: combine 32-bit constant loads into 64-bit ones

2018-07-05 Thread Rhys Perry
movs don't work with indirect loads such as c[r0+5]. This should only combine indirect loads, since they can't be movs. On Thu, Jul 5, 2018 at 12:04 PM, Ilia Mirkin wrote: > Loads require barriers, while movs don't. I believe that's why the blob > prefers 32-bit loads, and we do too. Why change i

Re: [Mesa-dev] [PATCH] gm107/ir: combine 32-bit constant loads into 64-bit ones

2018-07-05 Thread Ilia Mirkin
Loads require barriers, while movs don't. I believe that's why the blob prefers 32-bit loads, and we do too. Why change it? On Thu, Jul 5, 2018, 06:21 Rhys Perry wrote: > Seems to increase GPR count by a few in some shaders, but also decreases > instruction count by a bit. > > This should only c

[Mesa-dev] [PATCH] gm107/ir: combine 32-bit constant loads into 64-bit ones

2018-07-05 Thread Rhys Perry
Seems to increase GPR count by a few in some shaders, but also decreases instruction count by a bit. This should only combine them when a mov can not be used (when the load is indirect). total instructions in shared programs : 5804448 -> 5754102 (-0.87%) total gprs used in shared programs: 67