[Mesa-dev] [PATCH] i965/blorp: Fix hiz ops on MSAA surfaces

2014-11-04 Thread Chris Forbes
Two things were broken here: - The depth/stencil surface dimensions were broken for MSAA. - Sample count was programmed incorrectly. Result was the depth resolve didn't work correctly on MSAA surfaces, and so sampling the surface later produced garbage. Fixes the new piglit test arb_texture_multi

[Mesa-dev] [PATCH] i965/blorp: Fix hiz ops on MSAA surfaces

2014-11-18 Thread Chris Forbes
Two things were broken here: - The depth/stencil surface dimensions were broken for MSAA. - Sample count was programmed incorrectly. Result was the depth resolve didn't work correctly on MSAA surfaces, and so sampling the surface later produced garbage. Fixes the new piglit test arb_texture_multi

Re: [Mesa-dev] [PATCH] i965/blorp: Fix hiz ops on MSAA surfaces

2014-11-06 Thread Anuj Phogat
On Tue, Nov 4, 2014 at 8:40 AM, Chris Forbes wrote: > Two things were broken here: > - The depth/stencil surface dimensions were broken for MSAA. > - Sample count was programmed incorrectly. > > Result was the depth resolve didn't work correctly on MSAA surfaces, and > so sampling the surface lat

Re: [Mesa-dev] [PATCH] i965/blorp: Fix hiz ops on MSAA surfaces

2014-11-06 Thread Chris Forbes
Thanks for the review. Ken has a slightly cleaner version of the patch which avoids adding the helper function. On Nov 7, 2014 2:29 AM, "Anuj Phogat" wrote: > > > On Tue, Nov 4, 2014 at 8:40 AM, Chris Forbes wrote: > >> Two things were broken here: >> - The depth/stencil surface dimensions were

Re: [Mesa-dev] [PATCH] i965/blorp: Fix hiz ops on MSAA surfaces

2014-11-18 Thread Kenneth Graunke
On Tuesday, November 18, 2014 09:49:53 PM Chris Forbes wrote: > Two things were broken here: > - The depth/stencil surface dimensions were broken for MSAA. > - Sample count was programmed incorrectly. > > Result was the depth resolve didn't work correctly on MSAA surfaces, and > so sampling the su

Re: [Mesa-dev] [PATCH] i965/blorp: Fix hiz ops on MSAA surfaces

2014-11-18 Thread Jordan Justen
On 2014-11-18 00:56:02, Kenneth Graunke wrote: > On Tuesday, November 18, 2014 09:49:53 PM Chris Forbes wrote: > > Two things were broken here: > > - The depth/stencil surface dimensions were broken for MSAA. > > - Sample count was programmed incorrectly. > > > > Result was the depth resolve didn'

Re: [Mesa-dev] [PATCH] i965/blorp: Fix hiz ops on MSAA surfaces

2014-11-18 Thread Chad Versace
On Tue 18 Nov 2014, Chris Forbes wrote: Two things were broken here: - The depth/stencil surface dimensions were broken for MSAA. - Sample count was programmed incorrectly. Result was the depth resolve didn't work correctly on MSAA surfaces, and so sampling the surface later produced garbage. F