[Mesa-dev] [PATCH] i965/fs: Don't allow OOB array access of images

2016-04-14 Thread Jason Ekstrand
We have had a guard against OOB array access of images on IVB for a long time, but it can actually cause hangs on any GPU generation. This can happen due to getting an untyped SURFACE_STATE for a typed message or vice-versa. We didn't used to hit this with the piglit test on anything other than I

Re: [Mesa-dev] [PATCH] i965/fs: Don't allow OOB array access of images

2016-04-15 Thread Mark Janes
Tested-by: Mark Janes Jason Ekstrand writes: > We have had a guard against OOB array access of images on IVB for a long > time, but it can actually cause hangs on any GPU generation. This can > happen due to getting an untyped SURFACE_STATE for a typed message or > vice-versa. We didn't used

Re: [Mesa-dev] [PATCH] i965/fs: Don't allow OOB array access of images

2016-04-15 Thread Francisco Jerez
Jason Ekstrand writes: > We have had a guard against OOB array access of images on IVB for a long > time, but it can actually cause hangs on any GPU generation. This can > happen due to getting an untyped SURFACE_STATE for a typed message or > vice-versa. Are you sure about that? AFAIK the "ar

Re: [Mesa-dev] [PATCH] i965/fs: Don't allow OOB array access of images

2016-04-15 Thread Francisco Jerez
Francisco Jerez writes: > Jason Ekstrand writes: > >> We have had a guard against OOB array access of images on IVB for a long >> time, but it can actually cause hangs on any GPU generation. This can >> happen due to getting an untyped SURFACE_STATE for a typed message or >> vice-versa. > > Are