Re: [Mesa-dev] [PATCH] i965/fs: Don't try to use bogus interpolation modes pre-Gen6.

2013-04-26 Thread Jordan Justen
Reviewed-by: Jordan Justen Tested-by: Jordan Justen On Fri, Apr 26, 2013 at 4:52 PM, Chris Forbes wrote: > Interpolation modes other than perspective-barycentric-pixel-center (and > their associated coefficients in the WM payload) only exist in Gen6 and > later. > > Unfortunately, if a varying

Re: [Mesa-dev] [PATCH] i965/fs: Don't try to use bogus interpolation modes pre-Gen6.

2013-04-26 Thread Kenneth Graunke
On 04/26/2013 04:52 PM, Chris Forbes wrote: Interpolation modes other than perspective-barycentric-pixel-center (and their associated coefficients in the WM payload) only exist in Gen6 and later. Unfortunately, if a varying was declared as `centroid`, we would blindly read the nonexistant values

Re: [Mesa-dev] [PATCH] i965/fs: Don't try to use bogus interpolation modes pre-Gen6.

2013-04-26 Thread Paul Berry
On 26 April 2013 16:52, Chris Forbes wrote: > Interpolation modes other than perspective-barycentric-pixel-center (and > their associated coefficients in the WM payload) only exist in Gen6 and > later. > > Unfortunately, if a varying was declared as `centroid`, we would blindly > read the nonexis

[Mesa-dev] [PATCH] i965/fs: Don't try to use bogus interpolation modes pre-Gen6.

2013-04-26 Thread Chris Forbes
Interpolation modes other than perspective-barycentric-pixel-center (and their associated coefficients in the WM payload) only exist in Gen6 and later. Unfortunately, if a varying was declared as `centroid`, we would blindly read the nonexistant values, and so produce all manner of bad behavior --