Re: [Mesa-dev] [PATCH] i965/fs: Use greater-equal cmod to implement maximum.

2015-08-31 Thread Matt Turner
On Fri, Aug 28, 2015 at 6:42 PM, Jordan Justen wrote: > On 2015-08-28 17:12:31, Matt Turner wrote: >> See commit 3b7f683f. > > That commit message seems short enough to replicate, although it is > also valuable to mention the hash here too. > > Reviewed-by: Jordan Justen Thanks! > It almost see

Re: [Mesa-dev] [PATCH] i965/fs: Use greater-equal cmod to implement maximum.

2015-08-28 Thread Jordan Justen
On 2015-08-28 17:12:31, Matt Turner wrote: > See commit 3b7f683f. That commit message seems short enough to replicate, although it is also valuable to mention the hash here too. Reviewed-by: Jordan Justen It almost seems like we could rename emit_minmax to emit_cmpsel, optionally make it privat

[Mesa-dev] [PATCH] i965/fs: Use greater-equal cmod to implement maximum.

2015-08-28 Thread Matt Turner
See commit 3b7f683f. --- src/mesa/drivers/dri/i965/brw_fs_builder.h | 2 ++ src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp | 8 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_builder.h b/src/mesa/drivers/dri/i965/brw_fs_bui