Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-23 Thread Chia-I Wu
On Mon, Sep 23, 2013 at 12:09 PM, Chia-I Wu olva...@gmail.com wrote: On Fri, Sep 20, 2013 at 10:50 PM, Paul Berry stereotype...@gmail.com wrote: On 17 September 2013 19:54, Chia-I Wu olva...@gmail.com wrote: Hi Paul, On Mon, Sep 16, 2013 at 3:46 PM, Chia-I Wu olva...@gmail.com wrote: On

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-22 Thread Chia-I Wu
On Fri, Sep 20, 2013 at 10:50 PM, Paul Berry stereotype...@gmail.com wrote: On 17 September 2013 19:54, Chia-I Wu olva...@gmail.com wrote: Hi Paul, On Mon, Sep 16, 2013 at 3:46 PM, Chia-I Wu olva...@gmail.com wrote: On Sat, Sep 14, 2013 at 5:15 AM, Paul Berry stereotype...@gmail.com

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-20 Thread Paul Berry
On 17 September 2013 19:54, Chia-I Wu olva...@gmail.com wrote: Hi Paul, On Mon, Sep 16, 2013 at 3:46 PM, Chia-I Wu olva...@gmail.com wrote: On Sat, Sep 14, 2013 at 5:15 AM, Paul Berry stereotype...@gmail.com wrote: On 12 September 2013 22:06, Chia-I Wu olva...@gmail.com wrote: From:

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-20 Thread Ian Romanick
On 09/20/2013 09:50 AM, Paul Berry wrote: On 17 September 2013 19:54, Chia-I Wu olva...@gmail.com mailto:olva...@gmail.com wrote: Hi Paul, On Mon, Sep 16, 2013 at 3:46 PM, Chia-I Wu olva...@gmail.com mailto:olva...@gmail.com wrote: On Sat, Sep 14, 2013 at 5:15 AM, Paul

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-20 Thread Kenneth Graunke
On 09/20/2013 08:30 AM, Ian Romanick wrote: On 09/20/2013 09:50 AM, Paul Berry wrote: [snip] Since the SAMPLER_MODE setting allows us to trade off quality vs performance, we're also interested to know whether a value less than 0x1f is sufficient to produce the performance improvement in

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-20 Thread Mark Mueller
Wow, it's not often we as developers get to attribute an unexplained performance improvement to silicon. I'm happy to say I guessed wrong here. Did this start specifically with Haswell and is it likely this will persist in future gen hardware - more specifically, what's the proper test by the

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-17 Thread Mark Mueller
On Mon, Sep 16, 2013 at 1:31 AM, Chia-I Wu olva...@gmail.com wrote: On Mon, Sep 16, 2013 at 4:12 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Sep 16, 2013 at 3:50 AM, Mark Mueller markkmuel...@gmail.com wrote: On Fri, Sep 13, 2013 at 2:15 PM, Paul Berry stereotype...@gmail.com

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-17 Thread Chia-I Wu
On Wed, Sep 18, 2013 at 6:27 AM, Mark Mueller markkmuel...@gmail.com wrote: On Mon, Sep 16, 2013 at 1:31 AM, Chia-I Wu olva...@gmail.com wrote: On Mon, Sep 16, 2013 at 4:12 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Sep 16, 2013 at 3:50 AM, Mark Mueller markkmuel...@gmail.com wrote:

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-17 Thread Chia-I Wu
Hi Paul, On Mon, Sep 16, 2013 at 3:46 PM, Chia-I Wu olva...@gmail.com wrote: On Sat, Sep 14, 2013 at 5:15 AM, Paul Berry stereotype...@gmail.com wrote: On 12 September 2013 22:06, Chia-I Wu olva...@gmail.com wrote: From: Chia-I Wu o...@lunarg.com Consider only the top-left and top-right

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-16 Thread Chia-I Wu
On Sat, Sep 14, 2013 at 5:15 AM, Paul Berry stereotype...@gmail.com wrote: On 12 September 2013 22:06, Chia-I Wu olva...@gmail.com wrote: From: Chia-I Wu o...@lunarg.com Consider only the top-left and top-right pixels to approximate DDX in a 2x2 subspan, unless the application or the user

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-16 Thread Chia-I Wu
On Mon, Sep 16, 2013 at 3:50 AM, Mark Mueller markkmuel...@gmail.com wrote: On Fri, Sep 13, 2013 at 2:15 PM, Paul Berry stereotype...@gmail.com wrote: On 12 September 2013 22:06, Chia-I Wu olva...@gmail.com wrote: From: Chia-I Wu o...@lunarg.com Consider only the top-left and top-right

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-16 Thread Chia-I Wu
On Mon, Sep 16, 2013 at 4:12 PM, Chia-I Wu olva...@gmail.com wrote: On Mon, Sep 16, 2013 at 3:50 AM, Mark Mueller markkmuel...@gmail.com wrote: On Fri, Sep 13, 2013 at 2:15 PM, Paul Berry stereotype...@gmail.com wrote: On 12 September 2013 22:06, Chia-I Wu olva...@gmail.com wrote: From:

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-15 Thread Mark Mueller
On Fri, Sep 13, 2013 at 2:15 PM, Paul Berry stereotype...@gmail.com wrote: On 12 September 2013 22:06, Chia-I Wu olva...@gmail.com wrote: From: Chia-I Wu o...@lunarg.com Consider only the top-left and top-right pixels to approximate DDX in a 2x2 subspan, unless the application or the user

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-13 Thread Paul Berry
On 12 September 2013 22:06, Chia-I Wu olva...@gmail.com wrote: From: Chia-I Wu o...@lunarg.com Consider only the top-left and top-right pixels to approximate DDX in a 2x2 subspan, unless the application or the user requests a more accurate approximation. This results in a less accurate

[Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-12 Thread Chia-I Wu
From: Chia-I Wu o...@lunarg.com Consider only the top-left and top-right pixels to approximate DDX in a 2x2 subspan, unless the application or the user requests a more accurate approximation. This results in a less accurate approximation. However, it improves the performance of Xonotic with