Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-08-11 Thread Neil Roberts
Thanks for the review. I've pushed the Mesa patch and I'll have a look at adding more formats to the Piglit test. Regards, - Neil Kenneth Graunke kenn...@whitecape.org writes: On Tuesday, July 01, 2014 04:04:56 PM Neil Roberts wrote: FWIW, I relaxed the format restrictions in

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-08-08 Thread Kenneth Graunke
On Tuesday, July 01, 2014 04:04:56 PM Neil Roberts wrote: FWIW, I relaxed the format restrictions in brw_blorp_copytexsubimage, so it can handle general format conversions as well (i.e. RGBA_FLOAT16 - RGBA_UNORM). There's no reason we couldn't do that for BlitFramebuffer as well, I

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-07-01 Thread Neil Roberts
FWIW, I relaxed the format restrictions in brw_blorp_copytexsubimage, so it can handle general format conversions as well (i.e. RGBA_FLOAT16 - RGBA_UNORM). There's no reason we couldn't do that for BlitFramebuffer as well, I just forgot to do it (and then we decided to make it a newbie

[Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Neil Roberts
Previously the blorp blitter would only be used if the format is identical or there is only a difference between whether there is an alpha component or not. This patch makes it also allow the blorp blitter if the only difference is the ordering of the RGB components (ie, RGB or BGR). This is

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Matt Turner
On Mon, Jun 23, 2014 at 11:02 AM, Neil Roberts n...@linux.intel.com wrote: Previously the blorp blitter would only be used if the format is identical or there is only a difference between whether there is an alpha component or not. This patch makes it also allow the blorp blitter if the only

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Neil Roberts
Matt Turner matts...@gmail.com writes: We typically write Bugzilla: https:/// Reviewed-by: Matt Turner matts...@gmail.com Do you have commit access? Thanks for the review. I do have commit access so I've pushed the patch with the suggested change to the commit message. I've also

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Matt Turner
On Mon, Jun 23, 2014 at 12:06 PM, Neil Roberts n...@linux.intel.com wrote: Matt Turner matts...@gmail.com writes: We typically write Bugzilla: https:/// Reviewed-by: Matt Turner matts...@gmail.com Do you have commit access? Thanks for the review. I do have commit access so I've

Re: [Mesa-dev] [PATCH] i965: Allow the blorp blit between BGR and RGB

2014-06-23 Thread Kenneth Graunke
On Monday, June 23, 2014 07:02:59 PM Neil Roberts wrote: Previously the blorp blitter would only be used if the format is identical or there is only a difference between whether there is an alpha component or not. This patch makes it also allow the blorp blitter if the only difference is the