Re: [Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-20 Thread Juan A. Suarez Romero
On Thu, 2017-01-19 at 13:34 -0800, Chad Versace wrote: > +jason, juan > > Juan, here is the patch I mentioned earlier. It seems I had already sent > it to the list. > > It fixes the bug not by inserting additional checks before trying to > execute hiz ops, because that's just a workaround for

Re: [Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-19 Thread Chad Versace
On Thu 19 Jan 2017, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand And pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-19 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Jan 4, 2017 at 12:33 PM, Chad Versace wrote: > Fixes crash in piglit > `egl_khr_gl_renderbuffer_image-clear-shared-image GL_DEPTH_COMPONENT24` > on Skylake. > > The crash happened because blorp attempted to

Re: [Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-19 Thread Chad Versace
+jason, juan Juan, here is the patch I mentioned earlier. It seems I had already sent it to the list. It fixes the bug not by inserting additional checks before trying to execute hiz ops, because that's just a workaround for the real issue. The real issue is that intel_miptree_make_shareable()

Re: [Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-04 Thread Ben Widawsky
On 17-01-04 12:33:56, Chad Versace wrote: Fixes crash in piglit `egl_khr_gl_renderbuffer_image-clear-shared-image GL_DEPTH_COMPONENT24` on Skylake. The crash happened because blorp attempted to execute a pending hiz clear after the hiz buffer was deleted. Deleting the pending hiz ops when the

[Mesa-dev] [PATCH] i965: Delete pending CCS and HiZ ops in intel_miptree_make_shareable()

2017-01-04 Thread Chad Versace
Fixes crash in piglit `egl_khr_gl_renderbuffer_image-clear-shared-image GL_DEPTH_COMPONENT24` on Skylake. The crash happened because blorp attempted to execute a pending hiz clear after the hiz buffer was deleted. Deleting the pending hiz ops when the hiz buffer gets deleted fixes the crash. For