Re: [Mesa-dev] [PATCH] i965: Don't emit 3DSTATE_SAMPLER_STATE_POINTERS_VS for compute shaders.

Reviewed-by: Jordan Justen On 2017-10-31 01:58:41, Kenneth Graunke wrote: > For the render pipeline, the upload_sampler_state_table atom emits > 3DSTATE_BINDING_TABLE_POINTERS_XS. It tries to avoid this for compute: > >if (GEN_GEN >= 7 && stage_state->stage !=

Re: [Mesa-dev] [PATCH] i965: Don't emit 3DSTATE_SAMPLER_STATE_POINTERS_VS for compute shaders.

I think I'd prefer the commit message to say something like: i965: properly initialize brw->cs.base.stage to MESA_SHADER_COMPUTE and then keep all the VS stuff in the body of the message. That's a better description of the change even though the fallout is rather whacky. With that,

[Mesa-dev] [PATCH] i965: Don't emit 3DSTATE_SAMPLER_STATE_POINTERS_VS for compute shaders.

For the render pipeline, the upload_sampler_state_table atom emits 3DSTATE_BINDING_TABLE_POINTERS_XS. It tries to avoid this for compute: if (GEN_GEN >= 7 && stage_state->stage != MESA_SHADER_COMPUTE) { /* Emit a 3DSTATE_SAMPLER_STATE_POINTERS_XS packet. */