Re: [Mesa-dev] [PATCH] i965: Don't try to normalize cubemap coordinates for textureSize.

2011-11-11 Thread Eric Anholt
On Fri, 11 Nov 2011 02:07:00 -0800, Kenneth Graunke wrote: > Although textureSize is represented as an ir_texture with op == ir_txs, > it doesn't have a coordinate, so normalizing it doesn't make sense. > > Fixes crashes in oglconform glsl-bif-tex-size basic.samplerCube.* tests. Reviewed-by: Er

[Mesa-dev] [PATCH] i965: Don't try to normalize cubemap coordinates for textureSize.

2011-11-11 Thread Kenneth Graunke
Although textureSize is represented as an ir_texture with op == ir_txs, it doesn't have a coordinate, so normalizing it doesn't make sense. Fixes crashes in oglconform glsl-bif-tex-size basic.samplerCube.* tests. Signed-off-by: Kenneth Graunke --- .../drivers/dri/i965/brw_cubemap_normalize.cpp

Re: [Mesa-dev] [PATCH] i965: Don't try to normalize cubemap coordinates for textureSize.

2011-11-09 Thread Eric Anholt
On Wed, 9 Nov 2011 01:20:33 -0800, Kenneth Graunke wrote: > Although textureSize is represented as an ir_texture with op == ir_txs, > it doesn't have a coordinate, so normalizing it doesn't make sense. > > Fixes crashes in oglconform glsl-bif-tex-size basic.samplerCube.* tests. > > Signed-off-

[Mesa-dev] [PATCH] i965: Don't try to normalize cubemap coordinates for textureSize.

2011-11-09 Thread Kenneth Graunke
Although textureSize is represented as an ir_texture with op == ir_txs, it doesn't have a coordinate, so normalizing it doesn't make sense. Fixes crashes in oglconform glsl-bif-tex-size basic.samplerCube.* tests. Signed-off-by: Kenneth Graunke --- .../drivers/dri/i965/brw_cubemap_normalize.cpp