Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Kenneth Graunke
On 08/31/2012 12:54 PM, Jordan Justen wrote: > Reviewed-by: Jordan Justen > > 2 minor questions below... > > On Fri, Aug 31, 2012 at 12:22 AM, Kenneth Graunke > wrote: >> Haswell moved the "Cut Index Enable" bit from the INDEX_BUFFER packet to >> a new 3DSTATE_VF packet, so we need to emit tha

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Paul Berry
On 31 August 2012 13:16, Paul Berry wrote: > > Yeah, good point. I'd be ok with that. Keeping in mind, of course, that > after this patch lands, the bug will be in two places rather than one :) > Scratch that. Ken's patch implements my suggestion #1 for Haswell, so the bug only needs to be ad

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Paul Berry
On 31 August 2012 12:52, Jordan Justen wrote: > On Fri, Aug 31, 2012 at 12:08 PM, Paul Berry > wrote: > > On 31 August 2012 00:22, Kenneth Graunke wrote: > >> > >> Haswell moved the "Cut Index Enable" bit from the INDEX_BUFFER packet to > >> a new 3DSTATE_VF packet, so we need to emit that. Al

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Jordan Justen
Reviewed-by: Jordan Justen 2 minor questions below... On Fri, Aug 31, 2012 at 12:22 AM, Kenneth Graunke wrote: > Haswell moved the "Cut Index Enable" bit from the INDEX_BUFFER packet to > a new 3DSTATE_VF packet, so we need to emit that. Also, it requires us > to specify the cut index rather t

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Jordan Justen
On Fri, Aug 31, 2012 at 12:08 PM, Paul Berry wrote: > On 31 August 2012 00:22, Kenneth Graunke wrote: >> >> Haswell moved the "Cut Index Enable" bit from the INDEX_BUFFER packet to >> a new 3DSTATE_VF packet, so we need to emit that. Also, it requires us >> to specify the cut index rather than a

Re: [Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Paul Berry
On 31 August 2012 00:22, Kenneth Graunke wrote: > Haswell moved the "Cut Index Enable" bit from the INDEX_BUFFER packet to > a new 3DSTATE_VF packet, so we need to emit that. Also, it requires us > to specify the cut index rather than assuming it's 0x. > > This adds a new Haswell-specifi

[Mesa-dev] [PATCH] i965: Fix primitive restart on Haswell.

2012-08-31 Thread Kenneth Graunke
Haswell moved the "Cut Index Enable" bit from the INDEX_BUFFER packet to a new 3DSTATE_VF packet, so we need to emit that. Also, it requires us to specify the cut index rather than assuming it's 0x. This adds a new Haswell-specific tracked state atom to gen7_atoms. Normally, we would crea