Re: [Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2015-01-04 Thread Kenneth Graunke
On Sunday, January 04, 2015 12:03:01 PM Ben Widawsky wrote: > On Wed, Nov 12, 2014 at 11:17:55AM -0800, Kenneth Graunke wrote: > > According to the documentation, we need to do a CS stall on every fourth > > PIPE_CONTROL command to avoid GPU hangs. The kernel does a CS stall > > between batches, s

Re: [Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2015-01-04 Thread Ben Widawsky
On Wed, Nov 12, 2014 at 11:17:55AM -0800, Kenneth Graunke wrote: > According to the documentation, we need to do a CS stall on every fourth > PIPE_CONTROL command to avoid GPU hangs. The kernel does a CS stall > between batches, so we only need to count the PIPE_CONTROLs in our batches. > > v2: G

[Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2014-11-12 Thread Kenneth Graunke
According to the documentation, we need to do a CS stall on every fourth PIPE_CONTROL command to avoid GPU hangs. The kernel does a CS stall between batches, so we only need to count the PIPE_CONTROLs in our batches. v2: Get the generation check right (caught by Chris Wilson), combine the ++

Re: [Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2014-11-12 Thread Kenneth Graunke
On Wednesday, November 12, 2014 10:53:29 AM Chris Wilson wrote: > On Wed, Nov 12, 2014 at 11:39:28AM +0100, Daniel Vetter wrote: > > On Wed, Nov 12, 2014 at 01:33:01AM -0800, Kenneth Graunke wrote: > > > +/* Implement the WaCsStallAtEveryFourthPipecontrol workaround on IVB, BYT: > > > + * > > > +

Re: [Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2014-11-12 Thread Ian Romanick
On 11/12/2014 10:53 AM, Chris Wilson wrote: > On Wed, Nov 12, 2014 at 11:39:28AM +0100, Daniel Vetter wrote: >> On Wed, Nov 12, 2014 at 01:33:01AM -0800, Kenneth Graunke wrote: >>> +/* Implement the WaCsStallAtEveryFourthPipecontrol workaround on IVB, BYT: >>> + * >>> + * "Every 4th PIPE_CONTROL co

Re: [Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2014-11-12 Thread Ian Romanick
On 11/12/2014 10:39 AM, Daniel Vetter wrote: > On Wed, Nov 12, 2014 at 01:33:01AM -0800, Kenneth Graunke wrote: >> According to the documentation, we need to do a CS stall on every fourth >> PIPE_CONTROL command to avoid GPU hangs. The kernel does a CS stall >> between batches, so we only need to

Re: [Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2014-11-12 Thread Chris Wilson
On Wed, Nov 12, 2014 at 11:39:28AM +0100, Daniel Vetter wrote: > On Wed, Nov 12, 2014 at 01:33:01AM -0800, Kenneth Graunke wrote: > > +/* Implement the WaCsStallAtEveryFourthPipecontrol workaround on IVB, BYT: > > + * > > + * "Every 4th PIPE_CONTROL command, not counting the PIPE_CONTROL with > > +

Re: [Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2014-11-12 Thread Daniel Vetter
On Wed, Nov 12, 2014 at 01:33:01AM -0800, Kenneth Graunke wrote: > According to the documentation, we need to do a CS stall on every fourth > PIPE_CONTROL command to avoid GPU hangs. The kernel does a CS stall > between batches, so we only need to count the PIPE_CONTROLs in our batches. > > Signe

[Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

2014-11-12 Thread Kenneth Graunke
According to the documentation, we need to do a CS stall on every fourth PIPE_CONTROL command to avoid GPU hangs. The kernel does a CS stall between batches, so we only need to count the PIPE_CONTROLs in our batches. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h