Re: [Mesa-dev] [PATCH] i965: Initialize new chunks of realloc'd memory.

On Wednesday, July 09, 2014 12:41:25 PM Matt Turner wrote: > Otherwise we'd compare uninitialized pointers with NULL and dereference, > leading to crashes. > --- > src/mesa/drivers/dri/i965/intel_asm_annotation.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH] i965: Initialize new chunks of realloc'd memory.

Otherwise we'd compare uninitialized pointers with NULL and dereference, leading to crashes. --- src/mesa/drivers/dri/i965/intel_asm_annotation.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_asm_annotation.c b/src/mesa/drivers/dri/i965/intel_asm_annotati

Re: [Mesa-dev] [PATCH] i965: Initialize new chunks of realloc'd memory.

On Tue, Jul 8, 2014 at 9:51 PM, Chris Forbes wrote: > I think you want to move the memset after the !annotation->ann bail > out. Currently, if that allocation were to fail (and we care enough to > check...) , you'll segfault. Yeah... of course. Thanks. ___

Re: [Mesa-dev] [PATCH] i965: Initialize new chunks of realloc'd memory.

I think you want to move the memset after the !annotation->ann bail out. Currently, if that allocation were to fail (and we care enough to check...) , you'll segfault. On Wed, Jul 9, 2014 at 3:44 PM, Matt Turner wrote: > Otherwise we'd compare uninitialized pointers with NULL and dereference, > l

[Mesa-dev] [PATCH] i965: Initialize new chunks of realloc'd memory.

Otherwise we'd compare uninitialized pointers with NULL and dereference, leading to crashes. --- src/mesa/drivers/dri/i965/intel_asm_annotation.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_asm_annotation.c b/src/mesa/drivers/dri/i965/intel_asm_annotati