Iago Toral Quiroga writes:
> When doing software rendering (i.e. rendering to the selection buffer) we need
> to make sure that we have valid index bounds before calling _tnl_draw_prims(),
> otherwise we can crash.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59455
> ---
> src/mesa
When doing software rendering (i.e. rendering to the selection buffer) we need
to make sure that we have valid index bounds before calling _tnl_draw_prims(),
otherwise we can crash.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59455
---
src/mesa/drivers/dri/i965/brw_draw.c | 3 ++-
1 fi
On 03/27/2014 10:45 AM, Iago Toral Quiroga wrote:
> When doing software rendering (i.e. rendering to the selection buffer) we need
> to make sure that we have valid index bounds before calling _tnl_draw_prims(),
> otherwise we can crash.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=5
When doing software rendering (i.e. rendering to the selection buffer) we need
to make sure that we have valid index bounds before calling _tnl_draw_prims(),
otherwise we can crash.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59455
---
src/mesa/drivers/dri/i965/brw_draw.c | 3 ++-
1 fi
The proposed change works fine. Here is the updated patch.
Iago Toral Quiroga (1):
i965: Make sure we always compute valid index bounds before drawing.
src/mesa/drivers/dri/i965/brw_draw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
1.8.3.2
___
On 03/27/2014 02:18 AM, Iago Toral Quiroga wrote:
> Calling _tnl_draw_prims() with invalid index bounds can crash and
> in some cases where vbo_all_varyings_in_vbos() is TRUE but we
> don't have valid index bounds, this happens. This was producing
> a crash in Blender when rendering to the selectio
Calling _tnl_draw_prims() with invalid index bounds can crash and
in some cases where vbo_all_varyings_in_vbos() is TRUE but we
don't have valid index bounds, this happens. This was producing
a crash in Blender when rendering to the selection buffer.
Bugzilla: https://bugs.freedesktop.org/show_bug
There is crash in blender when rendering to the selection buffer and using VBO
that is caused because we call _tnl_draw_prims() without proper min_index
and max_index values.
As far as I can see it looks like these bounds should be computed by calling
vbo_get_minmax_indices() right before calling
