Re: [Mesa-dev] [PATCH] i965: Make vec4_visitor's destructor virtual

2015-10-05 Thread Iago Toral
On Mon, 2015-10-05 at 13:08 +0300, Francisco Jerez wrote: > Iago Toral Quiroga writes: > > > We need a virtual destructor when at least one of the class' methods is > > virtual. > > Failure to do so leads to undefined behavior when destructing derived > > classes. > > Fixes the following warnin

Re: [Mesa-dev] [PATCH] i965: Make vec4_visitor's destructor virtual

2015-10-05 Thread Francisco Jerez
Iago Toral Quiroga writes: > We need a virtual destructor when at least one of the class' methods is > virtual. > Failure to do so leads to undefined behavior when destructing derived classes. > Fixes the following warning: > > brw_vec4_gs_visitor.cpp: In function 'const unsigned int* > brw::br

[Mesa-dev] [PATCH] i965: Make vec4_visitor's destructor virtual

2015-10-05 Thread Iago Toral Quiroga
We need a virtual destructor when at least one of the class' methods is virtual. Failure to do so leads to undefined behavior when destructing derived classes. Fixes the following warning: brw_vec4_gs_visitor.cpp: In function 'const unsigned int* brw::brw_gs_emit(brw_context*, gl_shader_program*,