Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-10-02 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Mon, Sep 17, 2018 at 3:52 PM Fritz Koenig wrote: > In the GL_MESA_framebuffer_flip_y implementation > _mesa_is_winsys_fbo checks were replaced with > FlipY checks. rb->Name is also used to determine > if a buffer is winsys. > > v2: Fixes annotation [for emil] > >

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-10-01 Thread Fritz Koenig
On Mon, Sep 17, 2018 at 1:51 PM Fritz Koenig wrote: > > In the GL_MESA_framebuffer_flip_y implementation > _mesa_is_winsys_fbo checks were replaced with > FlipY checks. rb->Name is also used to determine > if a buffer is winsys. > > v2: Fixes annotation [for emil] > > Fixes: ab05dd183cc ("i965: i

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-09-20 Thread Fritz Koenig
On Wed, Aug 22, 2018 at 3:41 PM Jason Ekstrand wrote: > > On Wed, Aug 22, 2018 at 5:35 PM Fritz Koenig wrote: >> >> On Wed, Aug 22, 2018 at 3:09 PM Jason Ekstrand wrote: >> > >> > Two questions: >> > >> > 1) Have you grep'd through the rest of i965 looking for Name to make sure >> > you got th

[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-09-17 Thread Fritz Koenig
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. v2: Fixes annotation [for emil] Fixes: ab05dd183cc ("i965: implement GL_MESA_framebuffer_flip_y [v3]") --- src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-09-17 Thread Fritz Koenig
On Thu, Aug 23, 2018 at 11:01 AM Emil Velikov wrote: > > On Thu, 23 Aug 2018 at 18:41, Emil Velikov wrote: > > > > Hi Fritz, > > > > On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > > > > > In the GL_MESA_framebuffer_flip_y implementation > > > _mesa_is_winsys_fbo checks were replaced with

[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY (v2)

2018-08-23 Thread Fritz Koenig
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. v2: Fixes annotation [for emil] Fixes: ab05dd183cc ("i965: implement GL_MESA_framebuffer_flip_y [v3]") --- src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-23 Thread Fritz Koenig
On Thu, Aug 23, 2018 at 11:01 AM Emil Velikov wrote: > > On Thu, 23 Aug 2018 at 18:41, Emil Velikov wrote: > > > > Hi Fritz, > > > > On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > > > > > In the GL_MESA_framebuffer_flip_y implementation > > > _mesa_is_winsys_fbo checks were replaced with

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-23 Thread Emil Velikov
On Thu, 23 Aug 2018 at 18:41, Emil Velikov wrote: > > Hi Fritz, > > On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > > > In the GL_MESA_framebuffer_flip_y implementation > > _mesa_is_winsys_fbo checks were replaced with > > FlipY checks. rb->Name is also used to determine > > if a buffer is

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-23 Thread Emil Velikov
Hi Fritz, On Wed, 22 Aug 2018 at 23:01, Fritz Koenig wrote: > > In the GL_MESA_framebuffer_flip_y implementation > _mesa_is_winsys_fbo checks were replaced with > FlipY checks. rb->Name is also used to determine > if a buffer is winsys. This seems like it fixes your earlier patch, so you normal

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Jason Ekstrand
On Wed, Aug 22, 2018 at 5:35 PM Fritz Koenig wrote: > On Wed, Aug 22, 2018 at 3:09 PM Jason Ekstrand > wrote: > > > > Two questions: > > > > 1) Have you grep'd through the rest of i965 looking for Name to make > sure you got them all? > > Yes, I have. I believe that I got them all now. > > >

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Fritz Koenig
On Wed, Aug 22, 2018 at 3:09 PM Jason Ekstrand wrote: > > Two questions: > > 1) Have you grep'd through the rest of i965 looking for Name to make sure > you got them all? Yes, I have. I believe that I got them all now. > 2) Have you had a chance to run it through our CI system? No I haven't

Re: [Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Jason Ekstrand
Two questions: 1) Have you grep'd through the rest of i965 looking for Name to make sure you got them all? 2) Have you had a chance to run it through our CI system? On Wed, Aug 22, 2018 at 5:00 PM Fritz Koenig wrote: > In the GL_MESA_framebuffer_flip_y implementation > _mesa_is_winsys_fbo che

[Mesa-dev] [PATCH] i965: Replace checks for rb->Name with FlipY

2018-08-22 Thread Fritz Koenig
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. --- src/mesa/drivers/dri/i965/brw_blorp.c| 20 +--- src/mesa/drivers/dri/i965/intel_pixel_read.c | 4 ++--