Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-06 Thread Kenneth Graunke
On Monday, July 06, 2015 04:24:12 PM Emil Velikov wrote: > Hello gents, > > On 2 July 2015 at 08:45, Kenneth Graunke wrote: > > On Wednesday, July 01, 2015 10:16:28 AM Mike Stroyan wrote: > >> When there are no color buffer render targets, gen6 and gen7 still > >> use the first BLEND_STATE elemen

Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-06 Thread Emil Velikov
Hello gents, On 2 July 2015 at 08:45, Kenneth Graunke wrote: > On Wednesday, July 01, 2015 10:16:28 AM Mike Stroyan wrote: >> When there are no color buffer render targets, gen6 and gen7 still >> use the first BLEND_STATE element to determine alpha test. >> gen6_upload_blend_state was allocating

Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-02 Thread Mike Stroyan
I had actually made the change to gen8_upload_blend_state, but after reading through the gen8 PRM a few times I decided to back it out. It does seem that the initial gen8 BLEND_STATE DWord can disable alpha test. Of course, new hardware features may not always behave as described. In that case allo

Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-02 Thread Kenneth Graunke
On Wednesday, July 01, 2015 10:16:28 AM Mike Stroyan wrote: > When there are no color buffer render targets, gen6 and gen7 still > use the first BLEND_STATE element to determine alpha test. > gen6_upload_blend_state was allocating zero elements when > ctx->Color.AlphaEnabled was false. > That left

Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-01 Thread Chris Forbes
Reviewed-by: Chris Forbes On Thu, Jul 2, 2015 at 4:16 AM, Mike Stroyan wrote: > When there are no color buffer render targets, gen6 and gen7 still > use the first BLEND_STATE element to determine alpha test. > gen6_upload_blend_state was allocating zero elements when > ctx->Color.AlphaEnabled wa

Re: [Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-01 Thread Mike Stroyan
Fixes: (Flickering shadows in unreleased title trace) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80500 On Wed, Jul 1, 2015 at 10:16 AM, Mike Stroyan wrote: > When there are no color buffer render targets, gen6 and gen7 still > use

[Mesa-dev] [PATCH] i965: allocate at least 1 BLEND_STATE element

2015-07-01 Thread Mike Stroyan
When there are no color buffer render targets, gen6 and gen7 still use the first BLEND_STATE element to determine alpha test. gen6_upload_blend_state was allocating zero elements when ctx->Color.AlphaEnabled was false. That left _3DSTATE_CC_STATE_POINTERS or _3DSTATE_BLEND_STATE_POINTERS pointing t