Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

2017-06-15 Thread Emil Velikov
On 12 May 2017 at 05:06, Xu, Randy wrote: > Thanks, Rob > > Yes, I don’t test it w/ any gallium driver, please help. > Randy, even without the gallium testing I would encourage you to split and address the issue properly. If something is ambiguous (as I can be sometimes),

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

2017-05-11 Thread Rob Clark
I don't suppose anyone tested this already with any gallium driver? I suppose if not, I should (but I didn't bring the right board with me today so it might have to be tomorrow) BR, -R On Fri, May 5, 2017 at 3:17 AM, Xu, Randy wrote: > Ping Chad & Emil & Tapani > > Please

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

2017-05-11 Thread Xu, Randy
Got it, and I will follow this rule ;) Thanks, Randy > -Original Message- > From: Emil Velikov [mailto:emil.l.veli...@gmail.com] > Sent: Thursday, May 11, 2017 8:26 PM > To: Xu, Randy <randy...@intel.com> > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

2017-05-11 Thread Emil Velikov
Hi Randy, On 5 May 2017 at 08:17, Xu, Randy wrote: > Ping Chad & Emil & Tapani > > Please help to review it, I just verified it on Intel i965 driver. > All three of us are already subscribed to the list, so we get the patch ;-) Please don't ping immediately after you post a

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

2017-05-09 Thread Tapani Pälli
On 05/05/2017 10:14 AM, Randy Xu wrote: Follow up "i965: Solve Android native fence fd double close" The _EGLSync.SyncFd is not neccesary to keep after pass to dri driver. Test: Run Vulkan and GLES stress test and no crash. Yep I've verified as well that no crashes happen. Lots of tearing

Re: [Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

2017-05-05 Thread Xu, Randy
Ping Chad & Emil & Tapani Please help to review it, I just verified it on Intel i965 driver. Thanks, Randy > -Original Message- > From: Xu, Randy > Sent: Friday, May 5, 2017 3:15 PM > To: mesa-dev@lists.freedesktop.org > Cc: Xu, Randy > Subject: [PATCH] i965:

[Mesa-dev] [PATCH] i965: avoid fence fd dup in EGL layer

2017-05-05 Thread Randy Xu
Follow up "i965: Solve Android native fence fd double close" The _EGLSync.SyncFd is not neccesary to keep after pass to dri driver. Test: Run Vulkan and GLES stress test and no crash. --- src/egl/drivers/dri2/egl_dri2.c | 10 ++ src/mesa/drivers/dri/i965/brw_sync.c | 2 +- 2 files