Re: [Mesa-dev] [PATCH] intel: Fix decoding for partial STATE_BASE_ADDRESS updates.

2018-10-22 Thread Kenneth Graunke
On Monday, October 22, 2018 2:57:10 AM PDT Lionel Landwerlin wrote: > Could you maybe update src/intel/tools/aubinator_viewer_decoder.cpp > (function handle_state_base_address) ? > > Either way : > > Reviewed-by: Lionel Landwerlin Oops, good call, thanks! Pushed a v2 that updates both. sign

Re: [Mesa-dev] [PATCH] intel: Fix decoding for partial STATE_BASE_ADDRESS updates.

2018-10-22 Thread Lionel Landwerlin
Could you maybe update src/intel/tools/aubinator_viewer_decoder.cpp (function handle_state_base_address) ? Either way : Reviewed-by: Lionel Landwerlin On 22/10/2018 06:18, Kenneth Graunke wrote: STATE_BASE_ADDRESS only modifies various bases if the "modify" bit is set. Otherwise, we want to

[Mesa-dev] [PATCH] intel: Fix decoding for partial STATE_BASE_ADDRESS updates.

2018-10-21 Thread Kenneth Graunke
STATE_BASE_ADDRESS only modifies various bases if the "modify" bit is set. Otherwise, we want to keep the existing base address. Iris uses this for updating Surface State Base Address while leaving the others as-is. --- src/intel/common/gen_batch_decoder.c | 24 +--- 1 file c