[Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images [v3]

2011-11-18 Thread Chad Versace
For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of intel_mipmap_level were identical. In the exceptional case, nr_images == 6 and depth == 1. It is simple to determine if a texture is a cube or not, so the presence of two fields here was not helpful. Worse,

Re: [Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images [v3]

2011-11-18 Thread Kenneth Graunke
On 11/18/2011 04:19 PM, Chad Versace wrote: For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of intel_mipmap_level were identical. In the exceptional case, nr_images == 6 and depth == 1. It is simple to determine if a texture is a cube or not, so the

Re: [Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images

2011-10-24 Thread Roland Scheidegger
Am 23.10.2011 02:25, schrieb Kenneth Graunke: On 10/21/2011 08:45 PM, Chad Versace wrote: For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of intel_mipmap_level were identical. In the exceptional case, nr_images == 6 and depth == 1. It is simple to

Re: [Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images

2011-10-24 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/24/2011 10:12 AM, Roland Scheidegger wrote: Am 23.10.2011 02:25, schrieb Kenneth Graunke: On 10/21/2011 08:45 PM, Chad Versace wrote: For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of

Re: [Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images

2011-10-24 Thread Ian Romanick
On 10/24/2011 10:12 AM, Roland Scheidegger wrote: Am 23.10.2011 02:25, schrieb Kenneth Graunke: On 10/21/2011 08:45 PM, Chad Versace wrote: For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of intel_mipmap_level were identical. In the exceptional case,

Re: [Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images

2011-10-23 Thread Eric Anholt
On Fri, 21 Oct 2011 20:45:59 -0700, Chad Versace c...@chad-versace.us wrote: For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of intel_mipmap_level were identical. In the exceptional case, nr_images == 6 and depth == 1. It is simple to determine if a

Re: [Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images

2011-10-22 Thread Kenneth Graunke
On 10/21/2011 08:45 PM, Chad Versace wrote: For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of intel_mipmap_level were identical. In the exceptional case, nr_images == 6 and depth == 1. It is simple to determine if a texture is a cube or not, so the

[Mesa-dev] [PATCH] intel: Kill intel_mipmap_level::nr_images

2011-10-21 Thread Chad Versace
For all texture targets except GL_TEXTURE_CUBE_MAP, the 'nr_images' and 'depth' fields of intel_mipmap_level were identical. In the exceptional case, nr_images == 6 and depth == 1. It is simple to determine if a texture is a cube or not, so the presence of two fields here was not helpful. Worse,