Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-14 Thread Alejandro Piñeiro
On 13/08/18 20:43, Dylan Baker wrote: > This probably should have a Fixes tag? Yes, should had, but I pushed it as soon as I got a Rb :/ Sorry > > Quoting Alejandro Piñeiro (2018-08-13 07:50:38) >> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this >> patch replaces it with

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Dylan Baker
This probably should have a Fixes tag? Quoting Alejandro Piñeiro (2018-08-13 07:50:38) > From AppVeyor #8582, it seems that MSVC doesn't like uint, so this > patch replaces it with unsigned. > --- > > Note that Im not sure if this is the usual solution. As far as I see, > uint is used on other

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Roland Scheidegger
Am 13.08.2018 um 16:50 schrieb Alejandro Piñeiro: > From AppVeyor #8582, it seems that MSVC doesn't like uint, so this > patch replaces it with unsigned. Reviewed-by: Roland Scheidegger > --- > > Note that Im not sure if this is the usual solution. As far as I see, > uint is used on other

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Emil Velikov
On 13 August 2018 at 15:56, Alejandro Piñeiro wrote: > > > On 13/08/18 16:50, Alejandro Piñeiro wrote: >> From AppVeyor #8582, it seems that MSVC doesn't like uint, so this >> patch replaces it with unsigned. >> --- >> >> Note that Im not sure if this is the usual solution. As far as I see, >>

Re: [Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Alejandro Piñeiro
On 13/08/18 16:50, Alejandro Piñeiro wrote: > From AppVeyor #8582, it seems that MSVC doesn't like uint, so this > patch replaces it with unsigned. > --- > > Note that Im not sure if this is the usual solution. As far as I see, > uint is used on other source files. Having said so, just replacing

[Mesa-dev] [PATCH] mesa/glspirv: fix compilation with MSVC

2018-08-13 Thread Alejandro Piñeiro
From AppVeyor #8582, it seems that MSVC doesn't like uint, so this patch replaces it with unsigned. --- Note that Im not sure if this is the usual solution. As far as I see, uint is used on other source files. Having said so, just replacing for unsigned seems the easier way to fix this.