Re: [Mesa-dev] [PATCH] mesa/st/glsl_to_tgsi: fixup copy-paste mistake

2018-08-12 Thread Gert Wollny
Indeed, thanks for checking Reviewed-By: Gert Wollny Am Sonntag, den 12.08.2018, 15:49 +0200 schrieb Erik Faye-Lund: > This is clearly a copy-paste error; if we validate the reladdr2- > pointer, we don't want to traverse to the reladdr-pointer. Especially > since the check above shows that rela

[Mesa-dev] [PATCH] mesa/st/glsl_to_tgsi: fixup copy-paste mistake

2018-08-12 Thread Erik Faye-Lund
This is clearly a copy-paste error; if we validate the reladdr2-pointer, we don't want to traverse to the reladdr-pointer. Especially since the check above shows that reladdr could be NULL here. Noticed by Coverity. CID: 1438389, 1438390 Fixes: 568bda2f2d3 ("mesa/st/glsl_to_tgsi: Split arrays who