Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-11 Thread Roland Scheidegger
Am 09.08.2014 17:25, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 11:12 AM, Roland Scheidegger srol...@vmware.com wrote: Am 09.08.2014 16:33, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger srol...@vmware.com wrote: On closer look, it looks to me like it wouldn't be

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-11 Thread Ilia Mirkin
On Mon, Aug 11, 2014 at 10:56 AM, Roland Scheidegger srol...@vmware.com wrote: Am 09.08.2014 17:25, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 11:12 AM, Roland Scheidegger srol...@vmware.com wrote: Am 09.08.2014 16:33, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-09 Thread Marek Olšák
Acked-by: Marek Olšák marek.ol...@amd.com Marek On Sat, Aug 9, 2014 at 7:52 AM, Ilia Mirkin imir...@alum.mit.edu wrote: So... can I get a review on this? It's the last bit needed for ARB_gs5 (well, except for the actual setting of the extension bit to 1) The only additional change I have in

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-09 Thread Roland Scheidegger
On closer look, it looks to me like it wouldn't be all that difficult to make proper sampler array dcls (as you apparently get them quite easily from glsl) which is really my only problem with it but it's not really all that important so Reviewed-by: Roland Scheidegger srol...@vmware.com Am

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-09 Thread Ilia Mirkin
On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger srol...@vmware.com wrote: On closer look, it looks to me like it wouldn't be all that difficult to make proper sampler array dcls (as you apparently get them quite easily If you can briefly outline how you think that should be done, I'd be

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-09 Thread Roland Scheidegger
Am 09.08.2014 16:33, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger srol...@vmware.com wrote: On closer look, it looks to me like it wouldn't be all that difficult to make proper sampler array dcls (as you apparently get them quite easily If you can briefly

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-09 Thread Ilia Mirkin
On Sat, Aug 9, 2014 at 11:12 AM, Roland Scheidegger srol...@vmware.com wrote: Am 09.08.2014 16:33, schrieb Ilia Mirkin: On Sat, Aug 9, 2014 at 10:14 AM, Roland Scheidegger srol...@vmware.com wrote: On closer look, it looks to me like it wouldn't be all that difficult to make proper sampler

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-08 Thread Ilia Mirkin
So... can I get a review on this? It's the last bit needed for ARB_gs5 (well, except for the actual setting of the extension bit to 1) The only additional change I have in my local version is that instead of + inst-sampler_array_size = + ir-sampler-as_dereference_array() +

[Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-06 Thread Ilia Mirkin
Replace the plain sampler index with a register reference to a sampler. We also need to keep track of the sampler array size when there is a relative reference so that we can mark the whole array used. To facilitate implementation, we add a separate ADDR register that exclusively handles the

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-06 Thread Marek Olšák
I guess PIPE_SHADER_CAP_MAX_ADDRS is now useless, because it can be derived from GLSL_FEATURE_LEVEL, right? Marek On Wed, Aug 6, 2014 at 5:25 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Replace the plain sampler index with a register reference to a sampler. We also need to keep track of the

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-06 Thread Ilia Mirkin
pc-MaxAddressRegs = pc-MaxNativeAddressRegs = _min(screen-get_shader_param(screen, sh, PIPE_SHADER_CAP_MAX_ADDRS), MAX_PROGRAM_ADDRESS_REGS); Not really sure what that's referring to... ARB_vp/fp or something? Anyways, this is definitely a bit of a violation

Re: [Mesa-dev] [PATCH] mesa/st: add support for dynamic sampler offsets

2014-08-06 Thread Marek Olšák
On Wed, Aug 6, 2014 at 5:53 PM, Ilia Mirkin imir...@alum.mit.edu wrote: pc-MaxAddressRegs = pc-MaxNativeAddressRegs = _min(screen-get_shader_param(screen, sh, PIPE_SHADER_CAP_MAX_ADDRS), MAX_PROGRAM_ADDRESS_REGS); Not really sure what that's referring