[Mesa-dev] [PATCH] mesa: Add unpack_uint_z_row support for floating-point depth buffers

2012-02-01 Thread Ian Romanick
From: Ian Romanick This is a hack, and it will result in incorrect rendering. However, it does eliminate spurious warnings in several piglit CopyPixels tests that involve floating-point depth buffers. The real solution is to add a zf field to SWspan to store float Z values. When a float depth

Re: [Mesa-dev] [PATCH] mesa: Add unpack_uint_z_row support for floating-point depth buffers

2012-02-01 Thread Brian Paul
On 02/01/2012 02:38 PM, Ian Romanick wrote: From: Ian Romanick This is a hack, and it will result in incorrect rendering. However, it does eliminate spurious warnings in several piglit CopyPixels tests that involve floating-point depth buffers. The real solution is to add a zf field to SWspan

Re: [Mesa-dev] [PATCH] mesa: Add unpack_uint_z_row support for floating-point depth buffers

2012-02-02 Thread Henri Verbeet
On 1 February 2012 23:12, Brian Paul wrote: >> +static void >> +unpack_uint_z_Z32_FLOAT(const void *src, GLuint *dst, GLuint n) >> +{ >> +   const float *s = ((const float *)src); > > > More parens than necessary there. > The entire cast is unnecessary, IMO. But of course that would apply to the o

Re: [Mesa-dev] [PATCH] mesa: Add unpack_uint_z_row support for floating-point depth buffers

2012-02-02 Thread Ian Romanick
On 02/02/2012 06:41 AM, Henri Verbeet wrote: On 1 February 2012 23:12, Brian Paul wrote: +static void +unpack_uint_z_Z32_FLOAT(const void *src, GLuint *dst, GLuint n) +{ + const float *s = ((const float *)src); More parens than necessary there. The entire cast is unnecessary, IMO. But of