Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-10 Thread Courtney Goeltzenleuchter
Hi Brian, I think I've pushed this patch. Could you verify that I haven't broken anything? Thanks! Courtney On Fri, Jun 6, 2014 at 7:20 PM, Brian Paul bri...@vmware.com wrote: Reviewed-by: Brian Paul bri...@vmware.com Do you need someone to commit/push this for you? -Brian On

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-06 Thread Cody Northrop
Whoops, yes, you're right. ftell() of SEEK_END and strlen() are returning the same value, which does not include the terminating zero. Updated patch below. We use this quite a bit, much faster than editing large apitrace files Thanks, -C Signed-off-by: Cody Northrop c...@lunarg.com ---

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-06 Thread Brian Paul
Reviewed-by: Brian Paul bri...@vmware.com Do you need someone to commit/push this for you? -Brian On 06/06/2014 12:04 PM, Cody Northrop wrote: Whoops, yes, you're right. ftell() of SEEK_END and strlen() are returning the same value, which does not include the terminating zero. Updated patch

[Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-05 Thread Cody Northrop
The fixed size is insufficient for shaders I'm debugging. Rather than just bump it up, make it dynamic. Thanks, -C Signed-off-by: Cody Northrop c...@lunarg.com --- src/mesa/main/shaderapi.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: Fix substitution of large shaders

2014-06-05 Thread Brian Paul
On 06/05/2014 10:47 AM, Cody Northrop wrote: The fixed size is insufficient for shaders I'm debugging. Rather than just bump it up, make it dynamic. Thanks, -C Signed-off-by: Cody Northrop c...@lunarg.com mailto:c...@lunarg.com --- src/mesa/main/shaderapi.c | 14 +++--- 1 file