[Mesa-dev] [PATCH] mesa: Save and restore NV_fog_distance & FOG_COORD_SRC state

2018-06-25 Thread Nicholas Miell
FOG_DISTANCE_MODE_NV & FOG_COORD_SRC weren't getting saved into display lists or restored on glPopAttrib(GL_FOG_BIT). Signed-off-by: Nicholas Miell --- src/mesa/main/attrib.c | 4 src/mesa/main/dlist.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/src/mesa/main/attrib.c b/src/mesa

Re: [Mesa-dev] [PATCH] mesa: Save and restore NV_fog_distance & FOG_COORD_SRC state

2018-06-25 Thread Ian Romanick
On 06/25/2018 11:53 AM, Nicholas Miell wrote: > FOG_DISTANCE_MODE_NV & FOG_COORD_SRC weren't getting saved > into display lists or restored on glPopAttrib(GL_FOG_BIT). Good catch. How did you detect this? Do we have any test cases? > > Signed-off-by: Nicholas Miell > --- > src/mesa/main/attr

Re: [Mesa-dev] [PATCH] mesa: Save and restore NV_fog_distance & FOG_COORD_SRC state

2018-06-25 Thread Nicholas Miell
On 06/25/2018 12:04 PM, Ian Romanick wrote: > On 06/25/2018 11:53 AM, Nicholas Miell wrote: >> FOG_DISTANCE_MODE_NV & FOG_COORD_SRC weren't getting saved >> into display lists or restored on glPopAttrib(GL_FOG_BIT). > > Good catch. How did you detect this? Do we have any test cases? > I honest