Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-30 Thread Erik Faye-Lund
On Tue, 2018-10-30 at 08:20 -0400, Ilia Mirkin wrote: > On Tue, Oct 30, 2018 at 7:59 AM Erik Faye-Lund > wrote: > > > > On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote: > > > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund > > > wrote: > > > > > > > > From: Marek Olšák > > > > > > > >

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-30 Thread Ilia Mirkin
On Tue, Oct 30, 2018 at 7:59 AM Erik Faye-Lund wrote: > > On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote: > > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund > > wrote: > > > > > > From: Marek Olšák > > > > > > The spec was modified to support GLES. > > > > > > Tested-by: Erik Faye-Lund >

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-30 Thread Erik Faye-Lund
On Tue, 2018-10-30 at 07:44 -0400, Ilia Mirkin wrote: > On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund > wrote: > > > > From: Marek Olšák > > > > The spec was modified to support GLES. > > > > Tested-by: Erik Faye-Lund > > --- > > This replaces this patch: > >

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-30 Thread Ilia Mirkin
On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund wrote: > > From: Marek Olšák > > The spec was modified to support GLES. > > Tested-by: Erik Faye-Lund > --- > This replaces this patch: > https://patchwork.freedesktop.org/patch/257423/ > > docs/relnotes/18.3.0.html| 1 + >

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-30 Thread Erik Faye-Lund
On Fri, 2018-10-26 at 13:14 +0200, Erik Faye-Lund wrote: > On Thu, 2018-10-25 at 10:45 -0400, Ilia Mirkin wrote: > > Please confirm that this passes the piglit tests you sent to the > > list > > when run with ES2 forced, i.e. not ES3. > > (MESA_GLES_VERSION_OVERRIDE=2.0 iirc.) I'm concerned that

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-26 Thread Erik Faye-Lund
On Thu, 2018-10-25 at 10:45 -0400, Ilia Mirkin wrote: > Please confirm that this passes the piglit tests you sent to the list > when run with ES2 forced, i.e. not ES3. > (MESA_GLES_VERSION_OVERRIDE=2.0 iirc.) I'm concerned that the extra > logic was only added to _mesa_es3_error_check_bla and not

Re: [Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-25 Thread Ilia Mirkin
Please confirm that this passes the piglit tests you sent to the list when run with ES2 forced, i.e. not ES3. (MESA_GLES_VERSION_OVERRIDE=2.0 iirc.) I'm concerned that the extra logic was only added to _mesa_es3_error_check_bla and not the es2 paths. On Thu, Oct 25, 2018 at 6:59 AM Erik Faye-Lund

[Mesa-dev] [PATCH] mesa: expose EXT_texture_compression_s3tc on GLES

2018-10-25 Thread Erik Faye-Lund
From: Marek Olšák The spec was modified to support GLES. Tested-by: Erik Faye-Lund --- This replaces this patch: https://patchwork.freedesktop.org/patch/257423/ docs/relnotes/18.3.0.html| 1 + src/mesa/main/extensions_table.h | 2 +- src/mesa/main/glformats.c| 11