Re: [Mesa-dev] [PATCH] mesa: fix fallback texture for cube map array

2014-09-01 Thread Marek Olšák
On Thu, Aug 28, 2014 at 3:36 PM, Roland Scheidegger wrote: > Oops there's a bug in there, I'll send out a new version (we only pass a > one pixel sized array). > FWIW the msaa case also has its issues (generates a warning in > store_texsubimage, I guess that's pretty harmless though at the very >

[Mesa-dev] [PATCH] mesa: fix fallback texture for cube map array

2014-08-28 Thread sroland
From: Roland Scheidegger mesa was creating a cube map array texture with just one layer, which is not legal. This caused an assertion failure when using that texture later in llvmpipe (when enabling cube map arrays) since it verifies the number of layers in the view is divisible by 6 (the samplin

Re: [Mesa-dev] [PATCH] mesa: fix fallback texture for cube map array

2014-08-28 Thread Roland Scheidegger
Oops there's a bug in there, I'll send out a new version (we only pass a one pixel sized array). FWIW the msaa case also has its issues (generates a warning in store_texsubimage, I guess that's pretty harmless though at the very least the default value is going not to be what it should but who care

Re: [Mesa-dev] [PATCH] mesa: fix fallback texture for cube map array

2014-08-27 Thread Ian Romanick
Reviewed-by: Ian Romanick On 08/27/2014 06:00 PM, srol...@vmware.com wrote: > From: Roland Scheidegger > > mesa was creating a cube map array texture with just one layer, which is > not legal. This caused an assertion failure when using that texture later > in llvmpipe (when enabling cube map a

[Mesa-dev] [PATCH] mesa: fix fallback texture for cube map array

2014-08-27 Thread sroland
From: Roland Scheidegger mesa was creating a cube map array texture with just one layer, which is not legal. This caused an assertion failure when using that texture later in llvmpipe (when enabling cube map arrays) since it verifies the number of layers in the view is divisible by 6 (the samplin