Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-25 Thread Eric Engestrom
On Thursday, 2018-01-25 10:31:12 +0100, Marc Dietrich wrote: > Am Donnerstag, 25. Januar 2018, 10:28:26 CET schrieb Marc Dietrich: > > Am Donnerstag, 25. Januar 2018, 10:18:16 CET schrieb Eric Engestrom: > > > On Wednesday, 2018-01-24 22:02:42 +0100, Marc Dietrich wrote: > > > > Btw, there is

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-25 Thread Eric Engestrom
On Wednesday, 2018-01-24 22:02:42 +0100, Marc Dietrich wrote: > Btw, there is still some strange problem in PACKAGE_BUGREPORT as it > includes a "$" in the url. I don't know where this comes from. Where do you see this "$"? I've looked at the code and it looks all good to me.

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-24 Thread Dylan Baker
Quoting Marc Dietrich (2018-01-24 13:02:42) > Hi, > > Am Mittwoch, 24. Januar 2018, 18:41:17 CET schrieb Eric Engestrom: > > On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote: > > > Second hunk of fixes found by manual comparison with autotools generated > > > compiler flags. > > > >

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-24 Thread Marc Dietrich
Hi, Am Mittwoch, 24. Januar 2018, 18:41:17 CET schrieb Eric Engestrom: > On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote: > > Second hunk of fixes found by manual comparison with autotools generated > > compiler flags. > > > > Signed-off-by: Marc Dietrich > > --- >

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-24 Thread Dylan Baker
Quoting Eric Engestrom (2018-01-24 09:41:17) > On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote: > > Second hunk of fixes found by manual comparison with autotools generated > > compiler flags. > > > > Signed-off-by: Marc Dietrich > > --- > > - Why do we need two

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-24 Thread Dylan Baker
Quoting Marc Dietrich (2018-01-24 08:05:52) > Second hunk of fixes found by manual comparison with autotools generated > compiler flags. > > Signed-off-by: Marc Dietrich > --- > - Why do we need two version macros? > - And why do we either define DEBUG or NDEBUG? > - Also

Re: [Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-24 Thread Eric Engestrom
On Wednesday, 2018-01-24 17:05:52 +0100, Marc Dietrich wrote: > Second hunk of fixes found by manual comparison with autotools generated > compiler flags. > > Signed-off-by: Marc Dietrich > --- > - Why do we need two version macros? > - And why do we either define DEBUG or

[Mesa-dev] [PATCH] meson: fix some more defines meson.build

2018-01-24 Thread Marc Dietrich
Second hunk of fixes found by manual comparison with autotools generated compiler flags. Signed-off-by: Marc Dietrich --- - Why do we need two version macros? - And why do we either define DEBUG or NDEBUG? - Also autotools define some PACKAGE_ macros which are never used -