[Mesa-dev] [PATCH] meta/TexSubImage: Stash everything other than PIXEL_TRANSFER/store in meta_begin

2015-02-27 Thread Jason Ekstrand
Cc: 10.5 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89292 --- src/mesa/drivers/common/meta_tex_subimage.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src/mesa/drivers/common/meta_tex_subimage.c index 5ae12c

Re: [Mesa-dev] [PATCH] meta/TexSubImage: Stash everything other than PIXEL_TRANSFER/store in meta_begin

2015-02-27 Thread Jason Ekstrand
Alternatively, it's probably safe (and faster) to just save/restore the scissor in meta_begin/end. The _mesa_meta_BlitFramebuffer implementation stashes everything else anyway. --Jason On Fri, Feb 27, 2015 at 12:29 PM, Jason Ekstrand wrote: > Cc: 10.5 > Bugzilla: https://bugs.freedesktop.org/s

Re: [Mesa-dev] [PATCH] meta/TexSubImage: Stash everything other than PIXEL_TRANSFER/store in meta_begin

2015-03-02 Thread Jason Ekstrand
Ping. I don't want this one to get lost in the header file churn. --Jason On Feb 27, 2015 12:33 PM, "Jason Ekstrand" wrote: > Alternatively, it's probably safe (and faster) to just save/restore the > scissor in meta_begin/end. The _mesa_meta_BlitFramebuffer implementation > stashes everything e

Re: [Mesa-dev] [PATCH] meta/TexSubImage: Stash everything other than PIXEL_TRANSFER/store in meta_begin

2015-03-02 Thread Neil Roberts
This looks good to me. It does seem a shame to save everything though when so little state affects glBlitFramebuffer. However I think even if we changed it to just save the scissor state we'd still have a problem with not saving the the GL_FRAMEBUFFER_SRGB state which I think we also need to do. I