Re: [Mesa-dev] [PATCH] nir/copy_propagate: do not copy-propagate MOV srcs with source modifiers

2015-11-12 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Nov 11, 2015 at 11:34 PM, Iago Toral Quiroga wrote: > If a source operand in a MOV has source modifiers, then we cannot > copy-propagate it from the parent instruction and remove the MOV. > > v2: remove the check for source source modifiers from is_move() (Jas

[Mesa-dev] [PATCH] nir/copy_propagate: do not copy-propagate MOV srcs with source modifiers

2015-11-11 Thread Iago Toral Quiroga
If a source operand in a MOV has source modifiers, then we cannot copy-propagate it from the parent instruction and remove the MOV. v2: remove the check for source source modifiers from is_move() (Jason) --- src/glsl/nir/nir_opt_copy_propagate.c | 17 ++--- 1 file changed, 10 insertio

Re: [Mesa-dev] [PATCH] nir/copy_propagate: do not copy-propagate MOV srcs with source modifiers

2015-11-11 Thread Jason Ekstrand
On Wed, Nov 11, 2015 at 12:20 AM, Iago Toral Quiroga wrote: > If a source operand in a MOV has source modifiers, then we cannot > copy-propagate it from the parent instruction and remove the MOV. > --- > > I noticed this while debugging some regressions introduced with the fp64 > code. Basically,

[Mesa-dev] [PATCH] nir/copy_propagate: do not copy-propagate MOV srcs with source modifiers

2015-11-11 Thread Iago Toral Quiroga
If a source operand in a MOV has source modifiers, then we cannot copy-propagate it from the parent instruction and remove the MOV. --- I noticed this while debugging some regressions introduced with the fp64 code. Basically, I had code similar to this: vec4 ssa1 = intrincisc1 (...) (...) vec2 ss