Re: [Mesa-dev] [PATCH] nir/lower_vec_to_movs: Don't coalesce the mmove when src and dest are the same reg

2018-03-23 Thread Jason Ekstrand
After giving it some thought, I don't think this patch is quite strong enough to fix the real bug. The problem isn't that we're reswizzling a register. The problem is that we're trying to coalesce something like ssa_1 = fadd r1, r2 /* Some stuff */ r3 = vec4(ssa_1, ssa_1.y, ...) coalescing

Re: [Mesa-dev] [PATCH] nir/lower_vec_to_movs: Don't coalesce the mmove when src and dest are the same reg

2018-03-23 Thread Tapani Pälli
ping Jason .. On 22.03.2018 13:30, vadym.shovkoplias wrote: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105440 Fixes: 2458ea95c56 "nir/lower_vec_to_movs: Coalesce movs on-the-fly when possible" Signed-off-by: Andriy Khulap Signed-off-by: Vadym

[Mesa-dev] [PATCH] nir/lower_vec_to_movs: Don't coalesce the mmove when src and dest are the same reg

2018-03-22 Thread vadym.shovkoplias
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105440 Fixes: 2458ea95c56 "nir/lower_vec_to_movs: Coalesce movs on-the-fly when possible" Signed-off-by: Andriy Khulap Signed-off-by: Vadym Shovkoplias ---