Re: [Mesa-dev] [PATCH] nir/spirv: fix crashes when dereferencing a pointer for an OpVariable

2017-09-11 Thread Jason Ekstrand
On Mon, Sep 11, 2017 at 1:42 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > > > On 09/07/2017 07:15 PM, Jason Ekstrand wrote: > > On Tue, Aug 29, 2017 at 3:04 AM, Samuel Iglesias Gonsálvez < > sigles...@igalia.com> wrote: > >> When creating a vtn_pointer for an OpVariable, the bloc

Re: [Mesa-dev] [PATCH] nir/spirv: fix crashes when dereferencing a pointer for an OpVariable

2017-09-11 Thread Samuel Iglesias Gonsálvez
On 09/07/2017 07:15 PM, Jason Ekstrand wrote: > On Tue, Aug 29, 2017 at 3:04 AM, Samuel Iglesias Gonsálvez > mailto:sigles...@igalia.com>> wrote: > > When creating a vtn_pointer for an OpVariable, the block_index and > offsets fields are null because there is not ssa to take the data >

Re: [Mesa-dev] [PATCH] nir/spirv: fix crashes when dereferencing a pointer for an OpVariable

2017-09-07 Thread Jason Ekstrand
On Tue, Aug 29, 2017 at 3:04 AM, Samuel Iglesias Gonsálvez < sigles...@igalia.com> wrote: > When creating a vtn_pointer for an OpVariable, the block_index and > offsets fields are null because there is not ssa to take the data > from. > > However, we can dereference that pointer when processing an

Re: [Mesa-dev] [PATCH] nir/spirv: fix crashes when dereferencing a pointer for an OpVariable

2017-09-07 Thread Samuel Iglesias Gonsálvez
This patch is unreviewed. On Tue, 2017-08-29 at 12:04 +0200, Samuel Iglesias Gonsálvez wrote: > When creating a vtn_pointer for an OpVariable, the block_index and > offsets fields are null because there is not ssa to take the data > from. > > However, we can dereference that pointer when processi

[Mesa-dev] [PATCH] nir/spirv: fix crashes when dereferencing a pointer for an OpVariable

2017-08-29 Thread Samuel Iglesias Gonsálvez
When creating a vtn_pointer for an OpVariable, the block_index and offsets fields are null because there is not ssa to take the data from. However, we can dereference that pointer when processing an SpvOp*AccessChain opcodes through vtn_ssa_offset_pointer_dereference() when the OpVariable when the