Re: [Mesa-dev] [PATCH] nir: Add nir_lower_alu_scalar.

2015-01-23 Thread Eric Anholt
Jason Ekstrand writes: > Also, Could we rename this to nir_lower_alu_to_scalar? That's more > descriptive. That's even better. Done. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.free

Re: [Mesa-dev] [PATCH] nir: Add nir_lower_alu_scalar.

2015-01-22 Thread Jason Ekstrand
Also, Could we rename this to nir_lower_alu_to_scalar? That's more descriptive. --Jason On Thu, Jan 22, 2015 at 4:27 PM, Jason Ekstrand wrote: > > > On Thu, Jan 22, 2015 at 2:52 PM, Eric Anholt wrote: > >> This is the equivalent of brw_fs_channel_expressions.cpp, which I wanted >> for vc4. >>

Re: [Mesa-dev] [PATCH] nir: Add nir_lower_alu_scalar.

2015-01-22 Thread Jason Ekstrand
On Thu, Jan 22, 2015 at 2:52 PM, Eric Anholt wrote: > This is the equivalent of brw_fs_channel_expressions.cpp, which I wanted > for vc4. > > v2: Use the nir_src_for_ssa() helper, and another instance of > nir_alu_src_copy(). > v3: Drop the non-SSA support. All intended callers will have SSA

[Mesa-dev] [PATCH] nir: Add nir_lower_alu_scalar.

2015-01-22 Thread Eric Anholt
This is the equivalent of brw_fs_channel_expressions.cpp, which I wanted for vc4. v2: Use the nir_src_for_ssa() helper, and another instance of nir_alu_src_copy(). v3: Drop the non-SSA support. All intended callers will have SSA-only ALU ops. v4: Use insert_before, drop stale bcsel/fcsel