Re: [Mesa-dev] [PATCH] nir: Fix copy_prop_src when src is an indirect access on a reg.

2016-06-26 Thread Jason Ekstrand
Rb On Jun 25, 2016 9:30 PM, "Eric Anholt" wrote: > The intent was to continue down the indirect chain, not to call ourselves > with unchanged input arguments. Found by code inspection, and comparison > to copy_prop_alu_src(). > > We haven't hit this because callers of NIR's

Re: [Mesa-dev] [PATCH] nir: Fix copy_prop_src when src is an indirect access on a reg.

2016-06-26 Thread Rob Clark
On Sat, Jun 25, 2016 at 8:54 PM, Eric Anholt wrote: > The intent was to continue down the indirect chain, not to call ourselves > with unchanged input arguments. Found by code inspection, and comparison > to copy_prop_alu_src(). > > We haven't hit this because callers of NIR's

[Mesa-dev] [PATCH] nir: Fix copy_prop_src when src is an indirect access on a reg.

2016-06-25 Thread Eric Anholt
The intent was to continue down the indirect chain, not to call ourselves with unchanged input arguments. Found by code inspection, and comparison to copy_prop_alu_src(). We haven't hit this because callers of NIR's copy prop are doing so in SSA, before indirect variable dereferences have been