Re: [Mesa-dev] [PATCH] nir: Use nir_src_copy instead of direct assignments.

2017-07-18 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] nir: Use nir_src_copy instead of direct assignments.

2017-07-18 Thread Kenneth Graunke
If the source is an indirect register, there is ralloc'd data. Copying with a direct assignment will copy the pointer, but the data will still belong to the old instruction's memory context. Since we're lowering and throwing away instructions, that could free the data by mistake. Instead, use